From: Johannes Stezenbach <js@convergence.de>
To: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Cc: Ralf Baechle <ralf@uni-koblenz.de>,
linux-mips@fnet.fr, linux-mips@oss.sgi.com
Subject: Re: [patch] Oops and magic SysRq stack dump clean-ups
Date: Mon, 29 Jul 2002 18:02:48 +0200 [thread overview]
Message-ID: <20020729160248.GA2800@convergence.de> (raw)
In-Reply-To: <Pine.GSO.3.96.1020729150226.22288D-100000@delta.ds2.pg.gda.pl>
On Mon, Jul 29, 2002 at 03:25:53PM +0200, Maciej W. Rozycki wrote:
> I've reviewed the stack dumping code more thoroughly and here is the
> result. Please check if it's OK for you. Tested visually with oopses and
> <SysRq>+<t> on MIPS/Linux and MIPS64/Linux. The idea is to fit as much
> data as possible in as little space as possible and at the same time lay
> the numbers out visually nicely so that manual copying of output from a
> terminal for ksymoops analysis is easier for a reader. Tools ignore
> spacing when processing such output anyway.
>
> Based somewhat on the i386 port. Addresses cast to signed longs, since
> they are such on MIPS (additionally, the code doesn't care anyway but the
> resulting source is smaller). Any objections?
Nope, patch and its output look good to me.
Johannes
prev parent reply other threads:[~2002-07-29 16:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-24 18:17 _stext is ill-defined / SysRq-T broken Johannes Stezenbach
2002-07-25 10:08 ` Maciej W. Rozycki
2002-07-25 11:05 ` Johannes Stezenbach
2002-07-25 11:20 ` Maciej W. Rozycki
2002-07-25 11:47 ` Johannes Stezenbach
2002-07-29 13:25 ` [patch] Oops and magic SysRq stack dump clean-ups Maciej W. Rozycki
2002-07-29 16:02 ` Johannes Stezenbach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020729160248.GA2800@convergence.de \
--to=js@convergence.de \
--cc=linux-mips@fnet.fr \
--cc=linux-mips@oss.sgi.com \
--cc=macro@ds2.pg.gda.pl \
--cc=ralf@uni-koblenz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox