From: Ralf Baechle <ralf@linux-mips.org>
To: Kip Walker <kwalker@broadcom.com>
Cc: linux-mips@linux-mips.org
Subject: Re: 64-bit little endian semaphore bug
Date: Sat, 9 Nov 2002 20:42:13 +0100 [thread overview]
Message-ID: <20021109204213.A13826@bacchus.dhis.org> (raw)
In-Reply-To: <3DCC4AC2.EC7BD4E1@broadcom.com>; from kwalker@broadcom.com on Fri, Nov 08, 2002 at 03:37:38PM -0800
On Fri, Nov 08, 2002 at 03:37:38PM -0800, Kip Walker wrote:
> In the 64-bit kernel, the semaphore structure (like the 32-bit kernel)
> has waking and count fields swizzled so they line up the same in a
> 64-bit double word for either endian. However, the semaphore-helper.h
> function waking_non_zero_interruptible still has specialized code for
> little-endian manipulation of the fields as though they are swapped.
>
> Patch is attached, and fixes a pipe deadlock I was seeing (both the
> reader and writer were down'ing the semaphore).
>
> patch is against 2.5, but should be clean against 2.4 also.
Patch is ok. I tweaked it slightly to make the 2.4 and 2.5 versions
identical.
General request to everybody - cc me on all patches that you wish to
submit even if you're posting them to some list.
Ralf
prev parent reply other threads:[~2002-11-09 19:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-08 23:37 64-bit little endian semaphore bug Kip Walker
2002-11-09 19:42 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021109204213.A13826@bacchus.dhis.org \
--to=ralf@linux-mips.org \
--cc=kwalker@broadcom.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox