From: Ralf Baechle <ralf@linux-mips.org>
To: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Cc: linux-mips@linux-mips.org,
Karsten Merker <karsten@excalibur.cologne.de>,
Thiemo Seufer <ica2_ts@csv.ica.uni-stuttgart.de>
Subject: Re: [patch] R4000/R4400 64-bit errata handling
Date: Fri, 10 Jan 2003 15:47:45 +0100 [thread overview]
Message-ID: <20030110154745.D7699@linux-mips.org> (raw)
In-Reply-To: <Pine.GSO.3.96.1030110150339.23678K-100000@delta.ds2.pg.gda.pl>; from macro@ds2.pg.gda.pl on Fri, Jan 10, 2003 at 03:32:34PM +0100
On Fri, Jan 10, 2003 at 03:32:34PM +0100, Maciej W. Rozycki wrote:
> As you might already know there are a few nasty errata in the R4000 and
> the early R4400 that hit 64-bit operation badly. Here is proposed code to
> detect them. If an erratum is found in the processor and no workaround is
> applied to a kernel executable, the kernel refuses to run. In all cases
> the result of the probes is output to the bootstrap log.
>
> The code has bits that make use of features of non-standard tools
> (binutils and gcc). But it doesn't depend on them -- when built with
> standard tools and run on an affected system, a kernel will simply fail,
> and on good systems it will run normally. Therefore it's safe to apply,
> and if the ultimate implementation in the tools differs, the code may get
> adjusted appropriately later.
>
> I'd like to apply this code as soon as possible as I consider it a
> prerequisite for integrating 64-bit support for the DECstation (to prevent
> people from running unreliable code), so please tell me if there are any
> doubts about it. Errata descriptions are available at the MIPS site --
> see: 'http://www.mips.com/publications/r400_r5000.html'. Unfortunately,
> despite several attempts to get a permission to duplicate them within
> Linux sources, I failed to get one.
>
> I'd like to express my gratitude to Karsten and Thiemo for testing the
> code with their hardware. Without their help, I wouldn't be able to
> prepare appropriate tests for errata my hardware doesn't suffer from.
> + __save_and_cli(flags);
> + __restore_flags(flags);
I suggest to replace these with local_irq_save and local_irq_restore.
They're already deprecated for 2.4 and completly gone in 2.5.
Looks ok to me otherwise.
Ralf
next prev parent reply other threads:[~2003-01-10 14:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-10 14:32 [patch] R4000/R4400 64-bit errata handling Maciej W. Rozycki
2003-01-10 14:47 ` Ralf Baechle [this message]
2003-01-10 14:52 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030110154745.D7699@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=ica2_ts@csv.ica.uni-stuttgart.de \
--cc=karsten@excalibur.cologne.de \
--cc=linux-mips@linux-mips.org \
--cc=macro@ds2.pg.gda.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox