From: Jun Sun <jsun@mvista.com>
To: Vivien Chappelier <vivienc@nerim.net>
Cc: Ralf Baechle <ralf@oss.sgi.com>,
linux-mips@linux-mips.org, jsun@mvista.com
Subject: Re: [PATCH 2.5] r4k_switch task_struct/thread_info fixes
Date: Thu, 6 Feb 2003 16:36:47 -0800 [thread overview]
Message-ID: <20030206163647.F13258@mvista.com> (raw)
In-Reply-To: <Pine.LNX.4.21.0302032311160.25421-100000@melkor>; from vivienc@nerim.net on Mon, Feb 03, 2003 at 11:21:50PM +0100
Actually the following hunks are not right. ST_OFF
should be applied against the task_struct, which is a0,
not thread_info (t3). Try to back off the change and see if things
are ok.
Also see my next email before you rush into trying :-)
Jun
On Mon, Feb 03, 2003 at 11:21:50PM +0100, Vivien Chappelier wrote:
<snip>
> /*
> * clear saved user stack CU1 bit
> */
> - ld t0, ST_OFF(a0)
> + ld t0, ST_OFF(t3)
> li t1, ~ST0_CU1
> and t0, t0, t1
> - sd t0, ST_OFF(a0)
> + sd t0, ST_OFF(t3)
>
>
> sll t2, t0, 5
> Index: arch/mips/kernel/r4k_switch.S
> ===================================================================
> RCS file: /home/cvs/linux/arch/mips/kernel/r4k_switch.S,v
> retrieving revision 1.29
> diff -u -r1.29 r4k_switch.S
> --- arch/mips/kernel/r4k_switch.S 5 Nov 2002 19:51:47 -0000 1.29
> +++ arch/mips/kernel/r4k_switch.S 3 Feb 2003 22:06:17 -0000
> @@ -67,10 +67,10 @@
> /*
> * clear saved user stack CU1 bit
> */
> - lw t0, ST_OFF(a0)
> + lw t0, ST_OFF(t3)
> li t1, ~ST0_CU1
> and t0, t0, t1
> - sw t0, ST_OFF(a0)
> + sw t0, ST_OFF(t3)
>
> FPU_SAVE_DOUBLE(a0, t0) # clobbers t0
>
>
next prev parent reply other threads:[~2003-02-07 0:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-03 22:21 [PATCH 2.5] r4k_switch task_struct/thread_info fixes Vivien Chappelier
2003-02-04 12:54 ` Ralf Baechle
2003-02-07 0:36 ` Jun Sun [this message]
2003-02-07 9:29 ` Vivien Chappelier
2003-02-07 18:40 ` Jun Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030206163647.F13258@mvista.com \
--to=jsun@mvista.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@oss.sgi.com \
--cc=vivienc@nerim.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox