From: Jun Sun <jsun@mvista.com>
To: Brian Murphy <brian@murphy.dk>
Cc: linux-mips@linux-mips.org, jsun@mvista.com
Subject: Re: [PATCH] allow CROSS_COMPILE override
Date: Thu, 20 Feb 2003 16:08:10 -0800 [thread overview]
Message-ID: <20030220160810.J7466@mvista.com> (raw)
In-Reply-To: <3E5550BA.4050107@murphy.dk>; from brian@murphy.dk on Thu, Feb 20, 2003 at 11:03:38PM +0100
On Thu, Feb 20, 2003 at 11:03:38PM +0100, Brian Murphy wrote:
> Jun Sun wrote:
>
> >Is this allowed? Can't find any such usage in kernel other
> >than the worrisome comment below:
> >
> >arch/arm/Makefile:# Grr, ?= doesn't work as all the other assignment operators do. Make bug?
> >
> >
> >
> >
> The arm code does this:
>
> # Only set INCDIR if its not already defined above
> # Grr, ?= doesn't work as all the other assignment operators do. Make bug?
> ifeq ($(origin INCDIR), undefined)
> INCDIR := $(MACHINE)
> endif
>
> where the make docs say:
>
> INCDIR ?= $(MACHINE)
>
> is the same as
>
> ifeq ($(origin INCDIR), undefined)
> INCDIR = $(MACHINE)
> endif
>
> which means INCDIR will reflect changes to MACHINE.
> The := form sets INCDIR once and for all. What do you want?
':=' is fine, as long as "?=" is deemed appropriate for kernel and hackers.
Jun
next prev parent reply other threads:[~2003-02-21 0:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-20 20:47 [PATCH] allow CROSS_COMPILE override Jun Sun
2003-02-20 21:15 ` Brian Murphy
2003-02-20 21:23 ` Jun Sun
2003-02-20 21:35 ` Brian Murphy
2003-02-20 21:57 ` Pete Popov
2003-02-20 22:03 ` Brian Murphy
2003-02-21 0:08 ` Jun Sun [this message]
2003-02-20 21:57 ` Daniel Jacobowitz
2003-02-20 22:06 ` Brian Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030220160810.J7466@mvista.com \
--to=jsun@mvista.com \
--cc=brian@murphy.dk \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox