Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Jeff Baitis <baitisj@evolution.com>
To: Pete Popov <ppopov@mvista.com>
Cc: linux-mips@linux-mips.org
Subject: Improperly handled case in arch/mips/au1000/common/time.c
Date: Tue, 22 Apr 2003 12:54:50 -0700	[thread overview]
Message-ID: <20030422125450.E10148@luca.pas.lab> (raw)

Pete:

While struggling to get Linux up on Evolution's custom board based on the
Au1500, I discovered a poorly handled case in time.c; null interrupts are
handled should not affect the local IRQ count. (if the local IRQ count is not
decremented, tests for in_irq() fail.)

Thanks for taking a look at my patch!

-Jeff

Index: time.c
===================================================================
RCS file: /home/cvs/linux/arch/mips/au1000/common/time.c,v
retrieving revision 1.5.2.10
diff -u -r1.5.2.10 time.c
--- time.c      25 Mar 2003 14:30:19 -0000      1.5.2.10
+++ time.c      22 Apr 2003 19:47:24 -0000
@@ -114,6 +114,7 @@
        return;
 
 null:
+       irq_exit(cpu, irq);
        ack_r4ktimer(0);
 }

             reply	other threads:[~2003-04-22 19:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-22 19:54 Jeff Baitis [this message]
2003-04-22 20:20 ` Improperly handled case in arch/mips/au1000/common/time.c Pete Popov
2003-04-22 20:49   ` Ralf Baechle
2003-04-22 22:56 ` Jun Sun
2003-04-22 23:00   ` Pete Popov
2003-04-22 23:07     ` Jun Sun
2003-04-23 15:35     ` Dan Malek
2003-04-22 23:07   ` Ralf Baechle
2003-04-22 23:13     ` Jun Sun
2003-04-22 23:18       ` Pete Popov
2003-04-22 23:30         ` Jun Sun
2003-04-23  0:29       ` Ralf Baechle
2003-04-23 13:24         ` Maciej W. Rozycki
2003-04-22 23:17     ` Matthew Dharm
2003-04-22 23:17       ` Matthew Dharm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030422125450.E10148@luca.pas.lab \
    --to=baitisj@evolution.com \
    --cc=linux-mips@linux-mips.org \
    --cc=ppopov@mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox