From: Jean Tourrilhes <jt@bougret.hpl.hp.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: Jeff Garzik <jgarzik@pobox.com>, Ralf Baechle <ralf@gnu.org>,
linux-mips@linux-mips.org, irda-users@sourceforge.net
Subject: Re: [PATCH] au1k_ir - fix for 2.6
Date: Tue, 9 Dec 2003 16:22:14 -0800 [thread overview]
Message-ID: <20031210002214.GA12272@bougret.hpl.hp.com> (raw)
In-Reply-To: <20031209155440.2615b9cc.shemminger@osdl.org>
On Tue, Dec 09, 2003 at 03:54:40PM -0800, Stephen Hemminger wrote:
> This fixes some of the issues with the Alchemy irda driver for MIPS on
> 2.6.0-test11. Tested with cross compile. This driver is probably obsolete
> but it is one of the two remaining users of dev_alloc
>
> Changes:
> * irqreturn_t for irq routine
> * alloc_irdadev instead of dev_alloc
> * should work as non module
>
> Some mips build notes:
> * no way to enable the device at present since drivers/net/irda/Kconfig
> expects MIPS_A1000 and arch/mips/Kconfig defines SOC_AU1000!
> * include/asm-mips/timex.h does not define CLOCK_TICK_RATE for this
> that type. Code should probably be:
>
> #ifdef CONFIG_SGI_IP22
> #define CLOCK_TICK_RATE 1000000
> #else
> #define CLOCK_TICK_RATE 1193182
> #endif
I don't have the hardware and I'm not familiar with MIPS, so
if the authors doesn't answer, we will merge your patch as is.
Thanks...
Jean
next prev parent reply other threads:[~2003-12-10 0:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-09 23:54 [PATCH] au1k_ir - fix for 2.6 Stephen Hemminger
2003-12-10 0:22 ` Jean Tourrilhes [this message]
2003-12-11 20:06 ` Pete Popov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031210002214.GA12272@bougret.hpl.hp.com \
--to=jt@bougret.hpl.hp.com \
--cc=irda-users@sourceforge.net \
--cc=jgarzik@pobox.com \
--cc=jt@hpl.hp.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@gnu.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox