From: Ralf Baechle <ralf@linux-mips.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Jun Sun <jsun@mvista.com>,
Linux/MIPS Development <linux-mips@linux-mips.org>
Subject: Re: [PATCH 2.6] set up conswitchp when CONFIG_VT is set
Date: Thu, 22 Jan 2004 13:28:32 +0100 [thread overview]
Message-ID: <20040122122832.GA4482@linux-mips.org> (raw)
In-Reply-To: <Pine.GSO.4.58.0401221052100.1408@waterleaf.sonytel.be>
On Thu, Jan 22, 2004 at 10:52:59AM +0100, Geert Uytterhoeven wrote:
> | +#ifdef CONFIG_VT
> | +#if defined(CONFIG_VGA_CONSOLE)
> | + conswitchp = &vga_con;
> | +#elif defined(CONFIG_DUMMY_CONSOLE)
> | + conswitchp = &dummy_con;
> | +#endif
> | +#endif
>
> Isn't the #ifdef CONFIG_VT superfluous?
No; if CONFIG_VT is undefined conswitchp is undefined also; DUMMY_CONSOLE
however is still selectable if CONFIG_VT is off so there could be
unsatisfied references to consitchp.
ralf
next prev parent reply other threads:[~2004-01-22 12:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-22 0:20 [PATCH 2.6] set up conswitchp when CONFIG_VT is set Jun Sun
2004-01-22 9:52 ` Geert Uytterhoeven
2004-01-22 12:28 ` Ralf Baechle [this message]
2004-01-22 12:32 ` Geert Uytterhoeven
2004-01-22 22:18 ` Ralf Baechle
2004-01-22 22:44 ` Jun Sun
2004-01-22 22:44 ` Jun Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040122122832.GA4482@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=geert@linux-m68k.org \
--cc=jsun@mvista.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox