From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 22 Jan 2004 22:44:08 +0000 (GMT) Received: from gateway-1237.mvista.com ([IPv6:::ffff:12.44.186.158]:765 "EHLO orion.mvista.com") by linux-mips.org with ESMTP id ; Thu, 22 Jan 2004 22:44:07 +0000 Received: (from jsun@localhost) by orion.mvista.com (8.11.6/8.11.6) id i0MMi5i23622; Thu, 22 Jan 2004 14:44:05 -0800 Date: Thu, 22 Jan 2004 14:44:05 -0800 From: Jun Sun To: Ralf Baechle Cc: Geert Uytterhoeven , Linux/MIPS Development , jsun@mvista.com Subject: Re: [PATCH 2.6] set up conswitchp when CONFIG_VT is set Message-ID: <20040122144405.C3573@mvista.com> References: <20040121162032.F29705@mvista.com> <20040122122832.GA4482@linux-mips.org> <20040122221820.GA23391@linux-mips.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20040122221820.GA23391@linux-mips.org>; from ralf@linux-mips.org on Thu, Jan 22, 2004 at 11:18:20PM +0100 Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 4112 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: jsun@mvista.com Precedence: bulk X-list: linux-mips On Thu, Jan 22, 2004 at 11:18:20PM +0100, Ralf Baechle wrote: > On Thu, Jan 22, 2004 at 01:32:58PM +0100, Geert Uytterhoeven wrote: > > > DUMMY_CONSOLE can be set in drivers/video/console/Kconfig only. > > drivers/video/console/Kconfig is included by drivers/video/Kconfig only, and > > its inclusion depends on VT. > > Hence the #ifdef CONFIG_VT is superfluous, unless the above isn't true for the > > MIPS tree (I checked plain 2.6.1). > > A few systems used to hardwire CONFIG_DUMMY_CONSOLE in their Config.in / > Kconfig. Seem that has been fixed, good. > You are both right. In the end conswitchp needs to be set if and only if CONFIG_VT is set. >From this regard, I think it is OK to leave this config there even if not all that useful given current code. OK, I admit. I already checked it in that way :0 If anyone is seriously mad, I can take it out. It does not really matter. What really matters is we repealed another unnecessary tax on board part. Jun PS. the tax repealling thing is really learned from our governer Arnold Schwarzenegger .... From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 22 Jan 2004 14:44:05 -0800 From: Jun Sun Subject: Re: [PATCH 2.6] set up conswitchp when CONFIG_VT is set Message-ID: <20040122144405.C3573@mvista.com> References: <20040121162032.F29705@mvista.com> <20040122122832.GA4482@linux-mips.org> <20040122221820.GA23391@linux-mips.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040122221820.GA23391@linux-mips.org>; from ralf@linux-mips.org on Thu, Jan 22, 2004 at 11:18:20PM +0100 Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org To: Ralf Baechle Cc: Geert Uytterhoeven , Linux/MIPS Development , jsun@mvista.com Message-ID: <20040122224405.rC_n5XozrD27E4QFDbwx9fgCBQfqaW6hxYyGL4Fdb-U@z> On Thu, Jan 22, 2004 at 11:18:20PM +0100, Ralf Baechle wrote: > On Thu, Jan 22, 2004 at 01:32:58PM +0100, Geert Uytterhoeven wrote: > > > DUMMY_CONSOLE can be set in drivers/video/console/Kconfig only. > > drivers/video/console/Kconfig is included by drivers/video/Kconfig only, and > > its inclusion depends on VT. > > Hence the #ifdef CONFIG_VT is superfluous, unless the above isn't true for the > > MIPS tree (I checked plain 2.6.1). > > A few systems used to hardwire CONFIG_DUMMY_CONSOLE in their Config.in / > Kconfig. Seem that has been fixed, good. > You are both right. In the end conswitchp needs to be set if and only if CONFIG_VT is set.