Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Jun Sun <jsun@mvista.com>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: macro@ds2.pg.gda.pl, linux-mips@linux-mips.org, jsun@mvista.com
Subject: Re: [PATCH 2.6] enable genrtc for MIPS
Date: Mon, 2 Feb 2004 13:19:50 -0800	[thread overview]
Message-ID: <20040202131950.I18155@mvista.com> (raw)
In-Reply-To: <20040201.203005.74756858.anemo@mba.ocn.ne.jp>; from anemo@mba.ocn.ne.jp on Sun, Feb 01, 2004 at 08:30:05PM +0900

On Sun, Feb 01, 2004 at 08:30:05PM +0900, Atsushi Nemoto wrote:
> 
> By the way, with this patch, individual board can not implement it's
> own genrtc routines.  How about making gen_rtc_time, etc. pointer to
> functions to allow overrides?
> 

Is this necessary?  How about letting us wait until there is a sensible
need?

> I think implementing rtc_get_time (mips specific) with get_rtc_time
> (genrtc) is more efficient than implementing get_rtc_time with
> rtc_get_time for most RTC chips.
> 

If I understand you correctly, you like to have board rtc read routines to 
return a rtc structure instead of the unsigned long integer.

There are actually boards which makes the current implementation more efficient.  
See vr4181.

In general, however, this is not a bad idea, just involving a lot more
board level changes.  I think it deserves another patch or even debate.

Jun

  parent reply	other threads:[~2004-02-02 21:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-30 18:39 [PATCH 2.6] enable genrtc for MIPS Jun Sun
2004-01-30 19:13 ` Maciej W. Rozycki
2004-02-01 11:30   ` Atsushi Nemoto
2004-02-01 12:04     ` Geert Uytterhoeven
2004-02-02 21:19     ` Jun Sun [this message]
2004-02-03  1:30       ` Atsushi Nemoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040202131950.I18155@mvista.com \
    --to=jsun@mvista.com \
    --cc=anemo@mba.ocn.ne.jp \
    --cc=linux-mips@linux-mips.org \
    --cc=macro@ds2.pg.gda.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox