From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Mon, 02 Feb 2004 13:57:32 +0000 (GMT) Received: from p508B7363.dip.t-dialin.net ([IPv6:::ffff:80.139.115.99]:41024 "EHLO mail.linux-mips.net") by linux-mips.org with ESMTP id ; Mon, 2 Feb 2004 13:57:32 +0000 Received: from fluff.linux-mips.net (fluff.linux-mips.net [127.0.0.1]) by mail.linux-mips.net (8.12.8/8.12.8) with ESMTP id i12DvUex021975; Mon, 2 Feb 2004 14:57:30 +0100 Received: (from ralf@localhost) by fluff.linux-mips.net (8.12.8/8.12.8/Submit) id i12DvUAO021974; Mon, 2 Feb 2004 14:57:30 +0100 Date: Mon, 2 Feb 2004 14:57:30 +0100 From: Ralf Baechle To: "Maciej W. Rozycki" Cc: linux-mips@linux-mips.org Subject: Re: [patch] pg-r4k.c bugs for R4k systems with a secondary cache Message-ID: <20040202135730.GC21735@linux-mips.org> References: <20040201224958.GA11444@linux-mips.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040201224958.GA11444@linux-mips.org> User-Agent: Mutt/1.4.1i Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 4225 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: ralf@linux-mips.org Precedence: bulk X-list: linux-mips On Sun, Feb 01, 2004 at 11:49:58PM +0100, Ralf Baechle wrote: > > > The patch also removes references to has_scache which currently disable > > > code for the S-cache line size of 128 bytes as the variable is always 0. > > > > Here is a somewhat better version. It's functionally equivalent. OK to > > apply? > > Missed your mail and ran over it only now that I had just started to debug > the problem myself - but still before wasting a major amount of time ... > > Lemme test it on my R4400 V4.0 I'll report on it later. So the patch was looking good but didn't solve the problems with 128 byte S-cache lines. I've used your patch as a base and solved the remaining problems, will apply it in a minute. Ralf