From: Daniel Jacobowitz <dan@debian.org>
To: "Bradley D. LaRonde" <brad@laronde.org>
Cc: linux-mips@linux-mips.org, Eric Christopher <echristo@redhat.com>
Subject: Re: [PATCH] gcc 3.4 drops "accum" clobber, replace with "hi" intime.c
Date: Mon, 12 Apr 2004 21:07:32 -0400 [thread overview]
Message-ID: <20040413010732.GA7560@nevyn.them.org> (raw)
In-Reply-To: <04d501c420f3$6c836a30$8d01010a@prefect>
On Mon, Apr 12, 2004 at 09:05:34PM -0400, Bradley D. LaRonde wrote:
> ----- Original Message -----
> From: "Eric Christopher" <echristo@redhat.com>
> To: "Bradley D. LaRonde" <brad@laronde.org>
> Cc: <linux-mips@linux-mips.org>
> Sent: Monday, April 12, 2004 9:02 PM
> Subject: Re: [PATCH] gcc 3.4 drops "accum" clobber, replace with "hi"
> intime.c
>
>
> > On Mon, 2004-04-12 at 17:53, Bradley D. LaRonde wrote:
> > > Uh oh, with this patch:
> > >
> > > ...
> > > time.c: In function `fixed_rate_gettimeoffset':
> > > time.c:242: error: can't find a register in class `HI_REG' while
> reloading
> > > `asm'
> > > ...
> >
> > > >
> > > > /*
> > > > * Due to possible jiffies inconsistencies, we need to check
> > > > @@ -339,7 +339,7 @@
> > > > : "r" (timerhi), "m" (timerlo),
> > > > "r" (tmp), "r" (USECS_PER_JIFFY),
> > > > "r" (USECS_PER_JIFFY_FRAC)
> > > > - : "hi", "lo", "accum");
> > > > + : "hi", "lo", "hi");
> > > > cached_quotient = quotient;
> >
> >
> > Maybe this hunk where you use "hi" twice for the same asm statement?
>
> Yeah, that's messed up, but it fails here too:
>
> @@ -242,7 +242,7 @@
> __asm__("multu %1,%2"
> : "=h" (res)
> : "r" (count), "r" (sll32_usecs_per_cycle)
> - : "lo", "accum");
> + : "lo", "hi");
Because the asm is outputting something in HI - see the =h?
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
next prev parent reply other threads:[~2004-04-13 1:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-12 20:51 Work on IP30 Stanislaw Skowronek
2004-04-12 23:13 ` Ralf Baechle
2004-04-12 23:42 ` [PATCH] gcc 3.4 drops "accum" clobber, replace with "hi" in time.c Bradley D. LaRonde
2004-04-12 23:42 ` Bradley D. LaRonde
2004-04-13 0:53 ` Bradley D. LaRonde
2004-04-13 0:53 ` Bradley D. LaRonde
2004-04-13 1:02 ` Eric Christopher
2004-04-13 1:05 ` [PATCH] gcc 3.4 drops "accum" clobber, replace with "hi" intime.c Bradley D. LaRonde
2004-04-13 1:05 ` Bradley D. LaRonde
2004-04-13 1:07 ` Daniel Jacobowitz [this message]
2004-04-13 1:12 ` Bradley D. LaRonde
2004-04-13 1:12 ` Bradley D. LaRonde
2004-04-13 1:23 ` Bradley D. LaRonde
2004-04-13 1:23 ` Bradley D. LaRonde
2004-04-13 12:57 ` Maciej W. Rozycki
2004-04-18 2:39 ` Steven J. Hill
2004-04-19 11:50 ` Maciej W. Rozycki
2004-04-18 13:00 ` Ralf Baechle
2004-04-18 13:00 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040413010732.GA7560@nevyn.them.org \
--to=dan@debian.org \
--cc=brad@laronde.org \
--cc=echristo@redhat.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox