From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Sun, 16 May 2004 21:23:15 +0100 (BST) Received: from pfepc.post.tele.dk ([IPv6:::ffff:195.41.46.237]:3677 "EHLO pfepc.post.tele.dk") by linux-mips.org with ESMTP id ; Sun, 16 May 2004 21:23:14 +0100 Received: from mars.ravnborg.org (0x50a0757d.hrnxx9.adsl-dhcp.tele.dk [80.160.117.125]) by pfepc.post.tele.dk (Postfix) with ESMTP id 1C30726280A; Sun, 16 May 2004 22:23:09 +0200 (CEST) Received: by mars.ravnborg.org (Postfix, from userid 500) id B2957F550C; Sun, 16 May 2004 22:33:22 +0200 (CEST) Date: Sun, 16 May 2004 22:33:22 +0200 From: Sam Ravnborg To: Mathieu Chouquet-Stringer , linux-kernel@vger.kernel.org, rth@twiddle.net, linux-alpha@vger.kernel.org, ralf@gnu.org, linux-mips@linux-mips.org, akpm@osdl.org, bjornw@axis.com, dev-etrax@axis.com, mikael.starvik@axis.com Subject: Re: [PATCH] Fix for 2.6.6 Makefiles to get KBUILD_OUTPUT working Message-ID: <20040516203322.GA4784@mars.ravnborg.org> Mail-Followup-To: Mathieu Chouquet-Stringer , linux-kernel@vger.kernel.org, rth@twiddle.net, linux-alpha@vger.kernel.org, ralf@gnu.org, linux-mips@linux-mips.org, akpm@osdl.org, bjornw@axis.com, dev-etrax@axis.com, mikael.starvik@axis.com References: <20040516012245.GA11733@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040516012245.GA11733@localhost> User-Agent: Mutt/1.4.1i Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 5036 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: sam@ravnborg.org Precedence: bulk X-list: linux-mips On Sat, May 15, 2004 at 09:22:45PM -0400, Mathieu Chouquet-Stringer wrote: > Hi, > > if you use O=/someotherdir or KBUILD_OUTPUT=/someotherdir on the following > architectures: alpha, mips, sh and cris, the build process is probably > going to fail at one point or another, depending on the target you used, > because make can't find scripts/Makefile.build or scripts/Makefile.clean. > > The following patch (which should apply cleanly to the latest 2.6.6 bk > tree) fixes this, I greped the whole tree and these four were the only > "offenders" I found. Thanks, it has been on my todo for a while. A few comments though. > --- arch/mips/Makefile.orig 2004-05-15 20:48:52.000000000 -0400 > +++ arch/mips/Makefile 2004-05-15 20:49:58.000000000 -0400 > > -makeboot =$(Q)$(MAKE) -f scripts/Makefile.build obj=arch/mips/boot $(1) > +makeboot =$(Q)$(MAKE) $(build)=arch/mips/boot $(1) Please get rid of makeboot. Use $(Q)$(MAKE) ... instead. Hereby the '+' sign is no longer needed (used today where makeboot is used. > archclean: > - @$(MAKE) -f scripts/Makefile.clean obj=arch/mips/boot > - @$(MAKE) -f scripts/Makefile.clean obj=arch/mips/baget > - @$(MAKE) -f scripts/Makefile.clean obj=arch/mips/lasat > + @$(MAKE) $(clean)=arch/mips/boot > + @$(MAKE) $(clean)=arch/mips/baget > + @$(MAKE) $(clean)=arch/mips/lasat Please use $(Q)$(MAKE), so command is expanded with make V=1, and to make it look like all other usages. > --- arch/cris/Makefile.orig 2004-05-15 20:59:49.000000000 -0400 > +++ arch/cris/Makefile 2004-05-15 21:00:36.000000000 -0400 OK. But this file in general looks strange. There seems to be no way to descend into arch-v10? Mikael - any pending patches for this file / architecture? Mathieu, could you please update the patch and send onwards to Andrew. Do not touch the cris Makefile more than you did, the maintainer needs to clean it up. Thanks, Sam