From: Peter Horton <pdh@colonel-panic.org>
To: Jun Sun <jsun@mvista.com>
Cc: linux-mips@linux-mips.org
Subject: Re: problems on D-cache alias in 2.4.22
Date: Wed, 19 May 2004 00:29:21 +0100 [thread overview]
Message-ID: <20040518232921.GA13365@skeleton-jack> (raw)
In-Reply-To: <20040518152539.D5390@mvista.com>
On Tue, May 18, 2004 at 03:25:39PM -0700, Jun Sun wrote:
> >
> > IDE PIO fills the D-cache with the read data (write allocate) as it
> > copies it to the page cache.
> >
> > The kernel maps the page cache page into user space ... BANG! possible
> > D-cache alias.
> >
> > The kernel doesn't bother flushing the page cache page from the D-cache
> > as it's never accessed at it's page cache address.
> >
>
> The kernel (or driver) should flush the page if it is mapped to user space
> and the content is modified.
>
We just need a hook so that we can flush a page from the D-cache once
it's read from a block device into the page cache.
> > The current fix in the Cobalt patches (2.4 & 2.6) just flushes the read
> > data out of the D-cache after every IDE insw()/insl(). This is the least
> > intrusive fix.
> >
>
> It should be fixed at a higher layer before we return back to userland.
>
> If you can illustrate the call stack, I can probably take a look and
> give my opinion.
>
No call stack, sorry. It was months ago that I debugged this.
IIRC I picked up the aliases with memcmp() in do_no_page() in
mm/memory.c.
P.
next prev parent reply other threads:[~2004-05-18 23:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-18 18:17 problems on D-cache alias in 2.4.22 Bob Breuer
2004-05-18 18:17 ` Bob Breuer
2004-05-18 18:45 ` Jun Sun
2004-05-18 19:10 ` Peter Horton
2004-05-18 19:50 ` Ralf Baechle
2004-05-18 18:24 ` Alan Cox
2004-05-18 21:21 ` Peter Horton
2004-05-18 22:25 ` Jun Sun
2004-05-18 23:29 ` Peter Horton [this message]
2004-05-18 20:02 ` Ralf Baechle
2004-05-18 20:10 ` Thiemo Seufer
-- strict thread matches above, loose matches on Subject: below --
2004-05-13 22:05 Bob Breuer
2004-05-13 22:05 ` Bob Breuer
2004-05-14 2:59 ` wuming
2004-05-14 7:52 ` Peter Horton
2004-05-15 0:12 ` Ralf Baechle
2004-05-15 12:31 ` Fuxin Zhang
2004-05-13 6:52 wuming
2004-05-14 7:45 ` Peter Horton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040518232921.GA13365@skeleton-jack \
--to=pdh@colonel-panic.org \
--cc=jsun@mvista.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox