From: Vojtech Pavlik <vojtech@suse.cz>
To: Andrew Morton <akpm@osdl.org>
Cc: Jun Sun <jsun@mvista.com>,
linux-kernel@vger.kernel.org, linux-mips@linux-mips.org
Subject: Re: [PATCH] make ps2 mouse work ...
Date: Wed, 16 Jun 2004 14:11:49 +0200 [thread overview]
Message-ID: <20040616121149.GA9325@ucw.cz> (raw)
In-Reply-To: <20040615205611.1e9cbfcc.akpm@osdl.org>
On Tue, Jun 15, 2004 at 08:56:11PM -0700, Andrew Morton wrote:
> > I found this problem on a MIPS machine. The problem is
> > likely to happen on other register-rich RISC arches too.
> >
> > cmdcnt needs to be volatile since it is modified by
> > irq routine and read by normal process context.
>
> volatile is not the preferred way to fix this up. This points at either a
> locking error in the psmouse driver or a missing "memory" thingy in the
> mips port somewhere.
>
> Please describe the bug which led to this patch. Where was it getting stuck?
My current BK tree has this fixed using atomic bitfields, which do
compilation and memory barriers. I plan to sync it to Linus post 2.6.7.
--
Vojtech Pavlik
SuSE Labs, SuSE CR
next prev parent reply other threads:[~2004-06-16 12:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-16 2:10 [PATCH] make ps2 mouse work Jun Sun
2004-06-16 3:56 ` Andrew Morton
2004-06-16 3:56 ` Andrew Morton
2004-06-16 12:11 ` Vojtech Pavlik [this message]
2004-06-16 17:04 ` Jun Sun
2004-06-16 17:58 ` Vojtech Pavlik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040616121149.GA9325@ucw.cz \
--to=vojtech@suse.cz \
--cc=akpm@osdl.org \
--cc=jsun@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox