From: Ralf Baechle <ralf@linux-mips.org>
To: "Randy.Dunlap" <rddunlap@osdl.org>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS getdomainname() off by 1;
Date: Thu, 8 Jul 2004 02:49:51 +0200 [thread overview]
Message-ID: <20040708004951.GA17045@linux-mips.org> (raw)
In-Reply-To: <20040531202101.4ace5e95.rddunlap@osdl.org>
On Mon, May 31, 2004 at 08:21:01PM -0700, Randy.Dunlap wrote:
> irix_getdomainname() max size appears to be off by 1;
> other similar code in kernel uses __NEW_UTS_LEN as the max size,
> and <domainname> includes an extra byte for the terminating
> null character.
>
> Does sysirix.c need to limit <len> to 63 instead of 64 for some
> reason?
I would know why - and it has other bugs also, so I removed it by the
normal Linux getdomainname(2) for SysV flavour syscalls, too.
Ralf
next prev parent reply other threads:[~2004-07-08 0:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-01 3:21 [PATCH] MIPS getdomainname() off by 1; Randy.Dunlap
2004-07-08 0:49 ` Ralf Baechle [this message]
2004-07-08 8:46 ` Geert Uytterhoeven
2004-07-08 10:56 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040708004951.GA17045@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=rddunlap@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox