From: Ralf Baechle <ralf@linux-mips.org>
To: Kaj-Michael Lang <milang@tal.org>
Cc: linux-mips <linux-mips@linux-mips.org>
Subject: Re: cpu_has_llsc cleanup broke compilation.
Date: Tue, 17 Aug 2004 09:43:07 +0200 [thread overview]
Message-ID: <20040817074307.GA21407@linux-mips.org> (raw)
In-Reply-To: <001901c48427$6272acd0$54dc10c3@amos>
On Tue, Aug 17, 2004 at 09:56:53AM +0300, Kaj-Michael Lang wrote:
> The "using cpu_has_llsc cleanup all users of ll/sc and lld/scd." broke
> compilation:
>
> CC arch/mips/kernel/offset.s
> In file included from include/asm/bitops.h:35,
> from include/linux/bitops.h:4,
Clearly a kernel bug - but one that also shows poor maintenance of your
target. It should define cpu_has_llsc which it doesn't, so the kernel
will use generic code and deciede at runtime it should use ll/sc. I'm
fixing this problem but you really should fix your target also.
Ralf
next prev parent reply other threads:[~2004-08-17 7:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-17 6:56 cpu_has_llsc cleanup broke compilation Kaj-Michael Lang
2004-08-17 7:43 ` Ralf Baechle [this message]
2004-08-17 8:46 ` Kaj-Michael Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040817074307.GA21407@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=milang@tal.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox