From: Song Wang <wsonguci@yahoo.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
Subject: Re: Should #ifdef __KERNEL__ be added before #include <spaces.h> in asm-mips/addrspace.h ?
Date: Wed, 25 Aug 2004 12:34:58 -0700 (PDT) [thread overview]
Message-ID: <20040825193458.55841.qmail@web40001.mail.yahoo.com> (raw)
In-Reply-To: <20040820120526.GA27130@linux-mips.org>
Ralf,
The problem in asm-mips/addrspace.h when including
<spaces.h> is different. The problem is the path.
spaces.h lives in asm-mips/mach-generic,
Only when compiling kernel, asm-mips/mach-generic
is in the include path, because arch/mips/Makefile
defines it.
However, when compiling the user-space apps, they
don't know how to find spaces.h when they indirectly
include <asm/addrspace.h>
-Song
--- Ralf Baechle <ralf@linux-mips.org> wrote:
> On Tue, Jul 20, 2004 at 05:03:56PM -0700, Song Wang
> wrote:
>
> > Should #ifdef _KERNEL__ be added before #include
> > <spaces.h> in asm-mips/addrspace.h?
> >
> > I think the reason is the same as when you added
> > the #ifdef __KERNEL__ before #include <spaces.h>
> > for asm-mips/page.h.
>
> Some userspace software is expecting to get
> PAGE_SHIFT, PAGE_SIZE and
> PAGE_MASK to be available in userspace via
> <asm/page.h>, so I
> protected the inclusion of <asm/spaces.h> with
> __KERNEL__ but left
> the definitions of these symbols unprotected.
>
> Ralf
>
__________________________________
Do you Yahoo!?
New and Improved Yahoo! Mail - 100MB free storage!
http://promotions.yahoo.com/new_mail
prev parent reply other threads:[~2004-08-25 19:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-21 0:03 Should #ifdef __KERNEL__ be added before #include <spaces.h> in asm-mips/addrspace.h ? Song Wang
2004-08-20 12:05 ` Ralf Baechle
2004-08-25 19:34 ` Song Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040825193458.55841.qmail@web40001.mail.yahoo.com \
--to=wsonguci@yahoo.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox