From: Ralf Baechle <ralf@linux-mips.org>
To: Manish Lachwani <mlachwani@prometheus.mvista.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] Support for PMC-Sierra Ocelot-3 in 2.6
Date: Wed, 3 Nov 2004 00:07:33 +0100 [thread overview]
Message-ID: <20041102230733.GC28025@linux-mips.org> (raw)
In-Reply-To: <20041102201720.GB24674@prometheus.mvista.com>
On Tue, Nov 02, 2004 at 12:17:20PM -0800, Manish Lachwani wrote:
> +#ifdef CONFIG_MIPS64
> + 0xfffffffffc807000;
> +#else
> + 0xfc807000;
> +#endif
Ouch. Rather ugly. I suggest you rely on the implicit sign extension
of the compiler instead.
Ralf
next prev parent reply other threads:[~2004-11-02 22:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-02 20:17 [PATCH] Support for PMC-Sierra Ocelot-3 in 2.6 Manish Lachwani
2004-11-02 23:07 ` Ralf Baechle [this message]
2004-11-02 22:09 ` Manish Lachwani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041102230733.GC28025@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=mlachwani@prometheus.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox