From: Ralf Baechle <ralf@linux-mips.org>
To: Thiemo Seufer <ica2_ts@csv.ica.uni-stuttgart.de>
Cc: "Maciej W. Rozycki" <macro@linux-mips.org>,
Manish Lachwani <mlachwani@mvista.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Linux/MIPS Development <linux-mips@linux-mips.org>
Subject: Re: [PATCH] Synthesize TLB refill handler at runtime
Date: Wed, 24 Nov 2004 10:44:23 +0100 [thread overview]
Message-ID: <20041124094423.GB21039@linux-mips.org> (raw)
In-Reply-To: <20041124014057.GE902@rembrandt.csv.ica.uni-stuttgart.de>
On Wed, Nov 24, 2004 at 02:40:57AM +0100, Thiemo Seufer wrote:
> > default:
> > /*
> > * Others are assumed to have one cycle mtc0 hazard,
> > - * and one cycle tlbwr hazard.
> > + * and one cycle tlbwr hazard or to understand ehb.
> > * XXX: This might be overly general.
> > */
> > - i_nop(p);
> > + i_ehb(p);
> > i_tlbwr(p);
> > - i_nop(p);
> > + i_ehb(p);
> > break;
>
> Does r24k really need both delays? If not, it should get its own case.
> Probably it should be separated even if it is identical, the code above
> is nothing but a guess based on preexisting code.
I would suggest to default to EHB only for architecture revision 2. For
any pre-V2 processor the outcome of a default case is basically luck and
so I would suggest to just panic and force people to read their CPU
manual.
Ralf
next prev parent reply other threads:[~2004-11-24 9:46 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-21 17:02 [PATCH] Synthesize TLB refill handler at runtime Thiemo Seufer
2004-11-21 19:50 ` Geert Uytterhoeven
2004-11-21 20:37 ` Thiemo Seufer
2004-11-22 7:01 ` Ralf Baechle
2004-11-23 0:26 ` Manish Lachwani
2004-11-23 0:40 ` Maciej W. Rozycki
2004-11-23 2:17 ` Manish Lachwani
2004-11-23 20:24 ` Maciej W. Rozycki
2004-11-23 23:41 ` Manish Lachwani
2004-11-24 1:40 ` Thiemo Seufer
2004-11-24 9:44 ` Ralf Baechle [this message]
2004-11-24 15:04 ` Maciej W. Rozycki
2004-11-24 21:46 ` Maciej W. Rozycki
2004-11-24 22:12 ` Ralf Baechle
2004-11-24 22:39 ` Maciej W. Rozycki
2004-11-24 22:45 ` Ralf Baechle
2004-11-24 23:13 ` Maciej W. Rozycki
2004-11-24 2:16 ` Thiemo Seufer
2004-11-24 8:52 ` Ralf Baechle
2004-11-24 22:24 ` Manish Lachwani
2004-11-22 14:37 ` Maciej W. Rozycki
2004-11-22 15:56 ` Thiemo Seufer
2004-11-22 18:39 ` Maciej W. Rozycki
2004-11-21 20:43 ` Ralf Baechle
-- strict thread matches above, loose matches on Subject: below --
2004-11-29 19:14 Brad Larson
2004-11-29 19:47 ` Maciej W. Rozycki
2004-11-29 19:57 Brad Larson
2004-11-29 20:20 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041124094423.GB21039@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=geert@linux-m68k.org \
--cc=ica2_ts@csv.ica.uni-stuttgart.de \
--cc=linux-mips@linux-mips.org \
--cc=macro@linux-mips.org \
--cc=mlachwani@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox