From: Ralf Baechle <ralf@linux-mips.org>
To: Tatsuya Koseki <koseki@shimafuji.co.jp>
Cc: Linux MIPS mailing list <linux-mips@linux-mips.org>
Subject: Re: kernel 2.6.9 patch
Date: Wed, 15 Dec 2004 14:17:53 +0100 [thread overview]
Message-ID: <20041215131753.GC27935@linux-mips.org> (raw)
In-Reply-To: <009001c4e1ba$54a431f0$2100a8c0@koseki>
On Tue, Dec 14, 2004 at 05:53:02PM +0900, Tatsuya Koseki wrote:
> Subject: kernel 2.6.9 patch
> Date: Tue, 14 Dec 2004 17:53:02 +0900
> Content-Type: text/plain;
> charset="iso-2022-jp"
>
> Please review
>
>
> --- linux/include/asm/stackframe.h.old Tue Dec 14 17:49:38 2004
> +++ linux/include/asm/stackframe.h Tue Dec 14 17:50:35 2004
> @@ -244,6 +244,10 @@
> nor v1, $0, v1
> and v0, v1
> or v0, a0
> +
> + li v1,2
> + or v0,v1
> +
> mtc0 v0, CP0_STATUS
> LONG_L v1, PT_EPC(sp)
> MTC0 v1, CP0_EPC
o Your patch got corrupted by using a differnet indentation so couldn't be
applied anyway
o When posting a patch, post an explanation. If the purpose of a patch
isn't obvious it'll likely be ignroed.
o This bug was already fixed in CVS.
o The issue only affected new-born processes, so there is no reason to
burden the fix on every exception taken.
o Why using two instruction if one would be sufficient.
Ralf
next prev parent reply other threads:[~2004-12-15 13:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-14 8:53 kernel 2.6.9 patch Tatsuya Koseki
2004-12-15 13:17 ` Ralf Baechle [this message]
2004-12-16 2:53 ` Tatsuya Koseki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041215131753.GC27935@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=koseki@shimafuji.co.jp \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox