From: Ulrich Eckhardt <eckhardt@satorlaser.com>
To: linux-mips@linux-mips.org
Subject: conflicting declaration of prom_getcmdline()
Date: Fri, 1 Apr 2005 10:28:04 +0200 [thread overview]
Message-ID: <200504011028.04244.eckhardt@satorlaser.com> (raw)
Greetings!
I just stumbled over arch/mips/au1000/common/prom.c, which contains a function
defined like this:
char* prom_getcmdline(void);
EXPORT_SYMBOL(prom_getcmdline);
while there are implementations that define the function as
char* __init prom_getcmdline();
Further, there are several declarations throughout sourcefiles and in
include/asm-mips/mips-boards/prom.h and include/asm-mips/sgialib.h. Just grep
for it and you'll see the mess.
If anyone tells me which one is right and cares to explain why I hereby
volunteer to create a patch. ;)
Apart from that, some code in arch/mips/au1000/common/prom.c is unnecessarily
complicated.
cheers
Uli
next reply other threads:[~2005-04-01 8:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-01 8:28 Ulrich Eckhardt [this message]
2005-04-04 6:21 ` conflicting declaration of prom_getcmdline() Ralf Baechle
2005-04-04 11:20 ` Geert Uytterhoeven
2005-04-04 11:37 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200504011028.04244.eckhardt@satorlaser.com \
--to=eckhardt@satorlaser.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox