Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Ulrich Eckhardt <eckhardt@satorlaser.com>
To: linux-mips@linux-mips.org
Subject: When code and comments disagree...
Date: Wed, 6 Apr 2005 17:00:53 +0200	[thread overview]
Message-ID: <200504061700.53764.eckhardt@satorlaser.com> (raw)

... both are probably wrong, as the saying goes. I stumbled across this line 
in arch/mips/au1000/common/reset.c:

   au_writel(0x00, 0xb1900100); /* sys_pininputen */

However, 0xb1900100 is SYS_TRIOUTCLR, while SYS_PININPUTEN is 0xb1900110... 
Which one is right now?

Also, does the switch statement in that file make sense at all? I mean is it 
possible to compile a kernel that runs on several Alchemy systems?

Uli

             reply	other threads:[~2005-04-06 15:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-06 15:00 Ulrich Eckhardt [this message]
2005-04-06 20:19 ` When code and comments disagree Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200504061700.53764.eckhardt@satorlaser.com \
    --to=eckhardt@satorlaser.com \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox