From: Andy Isaacson <adi@hexapodia.org>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: Andrew Isaacson <adi@broadcom.com>, linux-mips@linux-mips.org
Subject: Re: [patch 4/5] SiByte fixes for 2.6.12
Date: Thu, 23 Jun 2005 07:49:27 -0700 [thread overview]
Message-ID: <20050623144926.GA10216@hexapodia.org> (raw)
In-Reply-To: <Pine.LNX.4.61L.0506231208120.17155@blysk.ds.pg.gda.pl>
On Thu, Jun 23, 2005 at 12:08:39PM +0100, Maciej W. Rozycki wrote:
> On Wed, 22 Jun 2005, Andrew Isaacson wrote:
> > If the CPU Options get out of sync with the CONFIG_CPU_ options,
> > cpu_cache_init() can end up being a noop. Stop with a useful message
> > in that case rather than running on without cache functions.
>
> Wouldn't a build-time error be a better option?
The code looks like it's structured to be able to be compiled with
support for multiple CPUs, say, r4k and SB1; using #error would seem to
prevent that.
With the code as currently structured, you don't know it's going to be a
noop until runtime comes along and cpu_has_4ktlb is true...
-andy
next prev parent reply other threads:[~2005-06-23 14:50 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-22 23:00 [patch 0/5] SiByte fixes for 2.6.12 Andrew Isaacson
2005-06-22 23:00 ` [patch 1/5] " Andrew Isaacson
2005-06-23 11:01 ` Maciej W. Rozycki
2005-06-23 23:26 ` Andy Isaacson
2005-10-01 9:28 ` Ralf Baechle
2005-10-03 11:56 ` Maciej W. Rozycki
2005-10-03 12:50 ` Ralf Baechle
2005-10-03 13:15 ` Daniel Jacobowitz
2005-10-03 13:24 ` Ralf Baechle
2005-10-03 13:35 ` Maciej W. Rozycki
2005-10-01 10:15 ` Ralf Baechle
2006-01-16 15:48 ` Martin Michlmayr
2006-01-23 12:55 ` Martin Michlmayr
2005-06-22 23:01 ` [patch 2/5] " Andrew Isaacson
2005-06-22 23:01 ` [patch 3/5] " Andrew Isaacson
2005-06-23 11:07 ` Maciej W. Rozycki
2005-06-23 19:48 ` Andy Isaacson
2005-06-30 16:43 ` Maciej W. Rozycki
2005-07-18 17:19 ` Maciej W. Rozycki
2005-06-22 23:01 ` [patch 4/5] " Andrew Isaacson
2005-06-23 11:08 ` Maciej W. Rozycki
2005-06-23 14:49 ` Andy Isaacson [this message]
2005-06-23 15:11 ` Maciej W. Rozycki
2005-06-23 22:27 ` Andy Isaacson
2005-10-01 11:57 ` Ralf Baechle
2005-06-22 23:02 ` [patch 5/5] " Andrew Isaacson
2005-10-01 12:07 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050623144926.GA10216@hexapodia.org \
--to=adi@hexapodia.org \
--cc=adi@broadcom.com \
--cc=linux-mips@linux-mips.org \
--cc=macro@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox