From: Ralf Baechle <ralf@linux-mips.org>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: linux-mips@linux-mips.org
Subject: Re: Fix zero length sys_cacheflush
Date: Wed, 19 Oct 2005 16:57:59 +0100 [thread overview]
Message-ID: <20051019155759.GJ2616@linux-mips.org> (raw)
In-Reply-To: <20051019.232222.59465169.anemo@mba.ocn.ne.jp>
On Wed, Oct 19, 2005 at 11:22:22PM +0900, Atsushi Nemoto wrote:
> BTW, sparse complains for this "unsigned long __user addr".
>
> asmlinkage int sys_cacheflush(unsigned long __user addr,
> unsigned long bytes, unsigned int cache)
>
> /work/git/linux-mips/arch/mips/mm/cache.c:59:7: warning: dereference of noderef expression
>
> I suppose the "unsigned long __user addr" means that the "addr"
> variable itself is an userspace object. So its usage is wrong, isn't
> it?
It didn't complain about this use in the past. Anyway, time to do another
pass with sparse over the code; sparse developers have invented alot of new
creative warnings ;-)
Ralf
prev parent reply other threads:[~2005-10-19 15:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-19 10:57 Fix zero length sys_cacheflush Atsushi Nemoto
2005-10-19 13:29 ` Ralf Baechle
2005-10-19 14:22 ` Atsushi Nemoto
2005-10-19 15:57 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051019155759.GJ2616@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox