From: Ralf Baechle <ralf@linux-mips.org>
To: Andrew Isaacson <adi@broadcom.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH 8/12] cerr-printk-not-prom-printf
Date: Thu, 20 Oct 2005 11:49:02 +0100 [thread overview]
Message-ID: <20051020104902.GA9491@linux-mips.org> (raw)
In-Reply-To: <20051020065757.GH23899@broadcom.com>
On Wed, Oct 19, 2005 at 11:57:57PM -0700, Andrew Isaacson wrote:
> Use printk rather than prom_printf in cache error handlers.
> prom_printf does not handle SMP locking, and shows up only
> on console (not in dmesg(1) or syslog).
This patch essentially reverses
http://www.linux-mips.org/git?p=linux.git;a=blobdiff;h=b2d41a2b0c406db6be87d02f51600e7e3013a748;hp=051290842231d9734d0bb2dc4c56b8590c4f5337;hb=760190d3f99ebabd965bd35324d5d084ff266711;f=arch/mips/mm/cerr-sb1.c
(Yuck, gitk URLs are bloody long ...)
The reason for this old commit was that this code is running uncached, so
the operation of ll/sc in the spinlocks is undefined according to the
MIPS64 spec, also there is a potencial deadlock since printk's
logbuf_lock might be held.
The old pass 1 part did truely exercise the cache error handler ;-)
Ralf
next prev parent reply other threads:[~2005-10-20 10:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-20 6:53 [PATCH 0/12] bcm1480 support Andrew Isaacson
2005-10-20 6:54 ` [PATCH 1/12] sibyte-fixes Andrew Isaacson
2005-10-20 6:55 ` [PATCH 2/12] 1480-headers Andrew Isaacson
2005-10-20 6:55 ` [PATCH 3/12] sibyte-header-cleanup Andrew Isaacson
2005-10-20 6:56 ` [PATCH 4/12] sb1a-support Andrew Isaacson
2005-10-20 6:56 ` [PATCH 5/12] 1480-support Andrew Isaacson
2005-10-20 6:57 ` [PATCH 6/12] bigsur-support Andrew Isaacson
2005-10-20 6:57 ` [PATCH 7/12] sb1-cache-exc-handling Andrew Isaacson
2005-10-20 6:57 ` [PATCH 8/12] cerr-printk-not-prom-printf Andrew Isaacson
2005-10-20 10:49 ` Ralf Baechle [this message]
2005-10-20 11:02 ` Dominic Sweetman
2005-10-20 11:17 ` Ralf Baechle
2005-10-20 6:58 ` [PATCH 9/12] sbmac-fixes Andrew Isaacson
2005-10-20 6:58 ` [PATCH 10/12] 1480-pci-support Andrew Isaacson
2005-10-20 6:59 ` [PATCH 11/12] 1480-ht-support Andrew Isaacson
2005-10-20 6:59 ` [PATCH 12/12] pci-expmem-hack Andrew Isaacson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051020104902.GA9491@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=adi@broadcom.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox