From: Ralf Baechle <ralf@linux-mips.org>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] remove mips_rtc_lock
Date: Thu, 3 Nov 2005 11:05:53 +0000 [thread overview]
Message-ID: <20051103110552.GA3149@linux-mips.org> (raw)
In-Reply-To: <20051103.010240.41630907.anemo@mba.ocn.ne.jp>
On Thu, Nov 03, 2005 at 01:02:40AM +0900, Atsushi Nemoto wrote:
> The mips_rtc_lock is no longer needed because RTC operations should be
> protected already by other mechanism. (rtc_lock, local_irq_save, etc.)
>
> Also, locking whole rtc_get_time/rtc_set_time should be avoided while
> some RTC routines might take very long time (a few seconds).
>
> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Applied. Thanks alot for the janitor work.
And also the function names are clear as mud:
[...]
static inline unsigned int get_rtc_time(struct rtc_time *time)
{
unsigned long nowtime;
nowtime = rtc_get_time();
[...]
static inline int set_rtc_time(struct rtc_time *time)
{
unsigned long nowtime;
int ret;
nowtime = mktime(time->tm_year+1900, time->tm_mon+1,
time->tm_mday, time->tm_hour, time->tm_min,
time->tm_sec);
ret = rtc_set_time(nowtime);
[...]
The difference between and get_rtc_time and rtc_get_time is less than
obvious. Same for set_rtc_time and rtc_set_time ...
Ralf
next prev parent reply other threads:[~2005-11-03 11:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-02 16:02 [PATCH] remove mips_rtc_lock Atsushi Nemoto
2005-11-03 11:05 ` Ralf Baechle [this message]
2005-11-03 14:12 ` Atsushi Nemoto
2005-11-03 14:26 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051103110552.GA3149@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox