Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: Stuart Anderson <anderson@netsweng.com>
Cc: David Daney <ddaney@avtrex.com>,
	crossgcc@sources.redhat.com,
	MIPS Linux List <linux-mips@linux-mips.org>
Subject: Re: linux kernel building for mips malta target board
Date: Thu, 3 Nov 2005 16:33:06 +0000	[thread overview]
Message-ID: <20051103163306.GC3149@linux-mips.org> (raw)
In-Reply-To: <Pine.LNX.4.61.0511022057140.3511@trantor.stuart.netsweng.com>

> I shamed myself into sitting down and doing this. 8-)
> 
> The attached patch seems to work, or at least doesn't seem to cause
> things to blow up. An o32 userspace on a 64-bit kernel comes up
> multi-user and can build a kernel, and run a quick subset of LTP.
> 
> There was a comment on IRC that there was a register allocation issue which
> lead to the current code. I'm not sure of the exact details, but I _think_
> this change ends up being equivilent to the code it replaces.

It's correct - but triggers plenty of extra warnings and you forgot about
get_user() which has the same kind of issue.  Also you don't have the
guarantee that <linux/types.h> has been included, so in order to avoid a
yet another header file dependency I changed s8, s16 etc. to char, short,
int, long long.  Working on it but as usual uaccess.h is quite a quiz.

  Ralf

  reply	other threads:[~2005-11-03 16:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1EXLJV-0005R4-K3@real.realitydiluted.com>
2005-11-03  0:45 ` linux kernel building for mips malta target board David Daney
2005-11-03  1:02   ` Stuart Anderson
2005-11-03  1:19     ` David Daney
2005-11-03  2:20       ` Stuart Anderson
2005-11-03 16:33         ` Ralf Baechle [this message]
2006-01-18 12:52           ` Martin Michlmayr
2006-01-18 13:05             ` Ralf Baechle
2006-01-18 13:37               ` Martin Michlmayr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051103163306.GC3149@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=anderson@netsweng.com \
    --cc=crossgcc@sources.redhat.com \
    --cc=ddaney@avtrex.com \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox