From: "Jordan Crouse" <jordan.crouse@amd.com>
To: "Pierre Ossman" <drzeus@drzeus.cx>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org,
"Russell King" <rmk+lkml@arm.linux.org.uk>
Subject: Re: ALCHEMY: Add SD support to AU1200 MMC/SD driver
Date: Fri, 2 Dec 2005 14:17:09 -0700 [thread overview]
Message-ID: <20051202211709.GL28227@cosmic.amd.com> (raw)
In-Reply-To: <4390A38A.1010907@drzeus.cx>
On 02/12/05 20:42 +0100, Pierre Ossman wrote:
> Jordan Crouse wrote:
> > @@ -196,7 +207,11 @@ static int au1xmmc_send_command(struct a
> >
> > switch(cmd->flags) {
> > case MMC_RSP_R1:
> > - mmccmd |= SD_CMD_RT_1;
> > + if (cmd->opcode == 0x03 && host->mmc->mode == MMC_MODE_SD)
> > + mmccmd |= SD_CMD_RT_6;
> > + else
> > + mmccmd |= SD_CMD_RT_1;
> > +
> > break;
> > case MMC_RSP_R1B:
> > mmccmd |= SD_CMD_RT_1B;
>
> No, no, no! Even if this wasn't already fixed in the current kernel you
> never hack around bugs in other parts of the kernel, you fix them!
As of a git pull about 30 minutes ago, both MMC_RSP_R1 and MMC_RSP_R6 resolve
to (MMC_RSP_SHORT|MMC_RSP_CRC). Now, I really wouldn't call that a
bug in the subsystem, because it is technically correct, but the Au1200
needs us to specifically specify if the required response is an R1 or
an R6, thus the specified logic.
Jordan
--
Jordan Crouse
Senior Linux Engineer
AMD - Personal Connectivity Solutions Group
<www.amd.com/embeddedprocessors>
next prev parent reply other threads:[~2005-12-02 21:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-02 19:01 [PATCH] ALCHEMY: Add SD support to AU1200 MMC/SD driver Jordan Crouse
2005-12-02 19:42 ` Pierre Ossman
2005-12-02 19:45 ` Russell King
2005-12-02 21:17 ` Jordan Crouse [this message]
2005-12-02 22:05 ` Pierre Ossman
2005-12-14 13:41 ` [PATCH] " Rodolfo Giometti
2005-12-14 15:53 ` Jordan Crouse
2006-01-09 17:45 ` Rodolfo Giometti
2006-01-09 18:19 ` Jordan Crouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051202211709.GL28227@cosmic.amd.com \
--to=jordan.crouse@amd.com \
--cc=drzeus@drzeus.cx \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox