From: Ralf Baechle <ralf@linux-mips.org>
To: Jordan Crouse <jordan.crouse@AMD.com>
Cc: bora.sahin@ttnet.net.tr, linux-mips@linux-mips.org
Subject: Re: Au1200 & IDE
Date: Thu, 15 Dec 2005 14:59:21 +0000 [thread overview]
Message-ID: <20051215145921.GB2812@linux-mips.org> (raw)
In-Reply-To: <20051214235031.GD23276@cosmic.amd.com>
On Wed, Dec 14, 2005 at 04:50:31PM -0700, Jordan Crouse wrote:
> > But that directory doesnt contain "ide-timing.h" so compiler complains from
> > it. ide-timing.h is in ide folder. I did a grep and saw that some other
> > dirs under ide also includes that file in the same manner as in mips but
> > doesnt contain it in its own folder. After I did a sym link, compile was
> > successfull. What's the concept behind this? Can we move it to
> > include/linux.
>
> I'm not sure about that - thats probably more of a question for the core
> folks. For your particular error, however, it should be sufficient to add
>
> EXTRA_CFLAGS += -Idrivers/ide
>
> To drivers/ide/mips/Makefile. I do believe that the most recent patches
> had that fix attached.
I nuked it - it just isn't necessary to force this for all drivers. So
if anything, make that
CFLAGS_au1xxx-ide.o += -Idrivers/ide
Ralf
prev parent reply other threads:[~2005-12-15 15:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-14 21:56 Au1200 & IDE bora.sahin
2005-12-14 23:50 ` Jordan Crouse
2005-12-15 9:58 ` bora.sahin
2005-12-15 14:59 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051215145921.GB2812@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=bora.sahin@ttnet.net.tr \
--cc=jordan.crouse@AMD.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox