From: Ralf Baechle <ralf@linux-mips.org>
To: Maxime Bizon <mbizon@freebox.fr>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] fix local_irq_save()/local_irq_restore() when CONFIG_CPU_MIPSR2 & CONFIG_IRQ_CPU
Date: Thu, 22 Dec 2005 02:48:10 +0100 [thread overview]
Message-ID: <20051222014810.GC1918@linux-mips.org> (raw)
In-Reply-To: <1135056739.9874.95.camel@sakura.staff.proxad.net>
On Tue, Dec 20, 2005 at 06:32:19AM +0100, Maxime Bizon wrote:
>
> I was unable to get my R4KECr2 board working with CONFIG_CPU_MIPSR2 &
> CONFIG_IRQ_CPU, irq delivery is not working.
>
> local_irq_restore() logic is to check that "flags" is non zero, and
> enable irq accordingly.
>
> But "flags" comes directly from di, which according to mips instruction
> set, saves whole status content, not just IE bit.
There are less local_irq_save than local_irq_restore calls, so is the
preferable place for the fix. Applied,
Ralf
prev parent reply other threads:[~2005-12-22 1:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-20 5:32 [PATCH] fix local_irq_save()/local_irq_restore() when CONFIG_CPU_MIPSR2 & CONFIG_IRQ_CPU Maxime Bizon
2005-12-20 12:00 ` Maciej W. Rozycki
2005-12-22 1:48 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051222014810.GC1918@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=mbizon@freebox.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox