From: Russell King <rmk@arm.linux.org.uk>
To: Jordan Crouse <jordan.crouse@amd.com>
Cc: linux-mips@linux-mips.org, drzeus@drzeus.cx
Subject: Re: [PATCH] Force MMC/SD to 512 byte block sizes
Date: Fri, 6 Jan 2006 16:59:30 +0000 [thread overview]
Message-ID: <20060106165930.GC16093@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20060106164406.GA15617@cosmic.amd.com>
On Fri, Jan 06, 2006 at 09:44:06AM -0700, Jordan Crouse wrote:
> This patch is not specific to the AU1200 SD driver, but thats what
> we used to debug and verify this, so thats why it is applied against
> the linux-mips tree. Pierre, I'm sending this to you too, because I thought
> you may be interested.
NACK. Please wait until the next round of patches get merged and then
revalidate this.
It's obviously wrong in the case of cards which do not support partial
block writes, and it does nothing to detect this (apart from violating
their advertised capabilities.)
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2006-01-06 16:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-06 16:44 [PATCH] Force MMC/SD to 512 byte block sizes Jordan Crouse
2006-01-06 16:59 ` Russell King [this message]
2006-01-06 17:42 ` Jordan Crouse
2006-01-09 17:49 ` Jordan Crouse
2006-01-06 17:04 ` [PATCH] " Pierre Ossman
2006-01-06 17:50 ` Jordan Crouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060106165930.GC16093@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=drzeus@drzeus.cx \
--cc=jordan.crouse@amd.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox