Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Oliver Neukum <oliver@neukum.org>
To: linux-usb-devel@lists.sourceforge.net
Cc: "Jordan Crouse" <jordan.crouse@amd.com>,
	linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
	info-linux@ldcmail.amd.com, thomas.dahlmann@amd.com
Subject: Re: [linux-usb-devel] [PATCH] UDC support for MIPS/AU1200 and Geode/CS5536
Date: Mon, 9 Jan 2006 23:44:55 +0100	[thread overview]
Message-ID: <200601092344.55988.oliver@neukum.org> (raw)
In-Reply-To: <20060109180356.GA8855@cosmic.amd.com>

Am Montag, 9. Januar 2006 19:03 schrieb Jordan Crouse:
> >From the "two-birds-one-stone" department, I am pleased to present USB UDC
> support for both the MIPS Au1200 SoC and the Geode CS5535 south bridge.  
> Also, coming soon (in the next few days), OTG, which has been removed from
> the usb_host patch, and put into its own patch (as per David's comments).
> 
> This patch is against current linux-mips git, but it should apply for Linus's
> tree as well.
> 
> Regards,
> Jordan
> 
+        VDBG("udc_read_bytes(): %d bytes\n", bytes);
+
+        /* dwords first */
+        for (i = 0; i < bytes / UDC_DWORD_BYTES; i++) {
+               *((u32*) (buf + (i<<2))) = readl(dev->rxfifo); 
+        }

Is there any reason you don't increment by 4?

	Regards
		Oliver

  parent reply	other threads:[~2006-01-09 22:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-09 18:03 [PATCH] UDC support for MIPS/AU1200 and Geode/CS5536 Jordan Crouse
2006-01-09 18:03 ` Jordan Crouse
2006-01-09 18:21 ` Jordan Crouse
2006-01-09 22:44 ` Oliver Neukum [this message]
2006-01-10 11:02   ` [linux-usb-devel] [PATCH] " Thomas Dahlmann
2006-01-10 13:16     ` David Vrabel
2006-01-10 13:40     ` Oliver Neukum
2006-01-13 10:08       ` Thomas Dahlmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200601092344.55988.oliver@neukum.org \
    --to=oliver@neukum.org \
    --cc=info-linux@ldcmail.amd.com \
    --cc=jordan.crouse@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    --cc=thomas.dahlmann@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox