From: Thiemo Seufer <ths@networkno.de>
To: "P. Christeas" <p_christ@hol.gr>
Cc: MIPS Linux List <linux-mips@linux-mips.org>
Subject: Re: Fixes for uaccess.h with gcc >= 4.0.1
Date: Mon, 23 Jan 2006 16:13:09 +0000 [thread overview]
Message-ID: <20060123161309.GA13459@networkno.de> (raw)
In-Reply-To: <200601231750.55246.p_christ@hol.gr>
On Mon, Jan 23, 2006 at 05:50:53PM +0200, P. Christeas wrote:
> On Monday 23 January 2006 5:37 pm, Ralf Baechle wrote:
> > On Mon, Jan 23, 2006 at 05:18:38PM +0200, P. Christeas wrote:
> > > On Monday 23 January 2006 5:05 pm, Ralf Baechle wrote:
> > > > I'd appreciate if somebody with gcc 4.0.1 could test this kernel patch
> > > > below.
> > > >
> > > > Ralf
> > >
> > > Is that for 2.4?
> >
> > 2.4 is a no go for all architectures with gcc >= 4.0.0 and in case of MIPS
> > even gcc 3.4 is somewhat dubious.
> >
> > > 2.6 doesn't seem to have that problem..
> >
> > It's probably a matter of configuration then. Basically with our current
> > uaccess.h and gcc >= 4.0.1 the attempt to pass a pointer to a const
> > variable as the pointer argument to get_user or __get_user will blow up.
> > It's always been a bug - but gcc before 4.0.1 were accepting this
> > silently.
> >
> > Ralf
>
> I 've been compiling with gcc 4.0.2 (my tree is Linus') and haven't seen any
> message like that.
The case I saw happened for 32bit compat ioctls in a 64bit kernel.
> It all compiles fine. Is there a point in testing your
> patch as well?
Well, if you want to be sure it doesn't break your system...
Thiemo
next prev parent reply other threads:[~2006-01-23 16:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-23 15:05 Fixes for uaccess.h with gcc >= 4.0.1 Ralf Baechle
2006-01-23 15:18 ` P. Christeas
2006-01-23 15:18 ` P. Christeas
2006-01-23 15:37 ` Ralf Baechle
2006-01-23 15:50 ` P. Christeas
2006-01-23 16:13 ` Thiemo Seufer [this message]
2006-01-23 15:45 ` Martin Michlmayr
2006-01-23 16:04 ` Rojhalat Ibrahim
2006-01-23 16:16 ` Ralf Baechle
2006-01-24 0:01 ` Stuart Anderson
2006-01-23 16:13 ` Martin Michlmayr
2006-02-07 20:21 ` Richard Sandiford
2006-02-10 1:34 ` Ralf Baechle
2006-02-11 13:44 ` Atsushi Nemoto
2006-02-14 6:57 ` Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060123161309.GA13459@networkno.de \
--to=ths@networkno.de \
--cc=linux-mips@linux-mips.org \
--cc=p_christ@hol.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox