Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <dan@debian.org>
To: Kumba <kumba@gentoo.org>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH]: Fix N32 sigsuspend syscall that causes non-fatal oopses
Date: Tue, 24 Jan 2006 14:34:59 -0500	[thread overview]
Message-ID: <20060124193459.GA24479@nevyn.them.org> (raw)
In-Reply-To: <20060124191741.GB31197@toucan.gentoo.org>

On Tue, Jan 24, 2006 at 07:17:41PM +0000, Kumba wrote:
> Fix to the sigsuspend syscall so N32 userlands work without triggering
> non-fatal oopses.  Patch was originally drafted by Daniel Jacobwitz.
> 
> Problem was originally discovered via a configure test in the glib
> package.  When run, the test triggered a segmentation fault and an
> oops, as well as causing the test, and ultimately, configure, to fail.
> 
> Signed-off-by: Joshua Kinard <kumba@gentoo.org>
> ---
> 
>  linux32.c     |   19 -------------------
>  scall64-n32.S |    4 ++--
>  signal.c      |   42 ++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 44 insertions(+), 21 deletions(-)

If you're going to mess around with sigsuspend, there's a better option
now: take a look at the recently added TIF_RESTORE_SIGMASK (committed
last week).

Everyone really should migrate over to that approach; it fixes (among
other things) a nasty debugging corner case and some code duplication.

-- 
Daniel Jacobowitz
CodeSourcery

  reply	other threads:[~2006-01-24 19:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-24 19:17 [PATCH]: Fix N32 sigsuspend syscall that causes non-fatal oopses Kumba
2006-01-24 19:34 ` Daniel Jacobowitz [this message]
2006-02-18 22:43   ` Ralf Baechle
  -- strict thread matches above, loose matches on Subject: below --
2006-01-23 20:45 Kumba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060124193459.GA24479@nevyn.them.org \
    --to=dan@debian.org \
    --cc=kumba@gentoo.org \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox