From: Ralf Baechle <ralf@linux-mips.org>
To: Martin Michlmayr <tbm@cyrius.com>
Cc: Kaj-Michael Lang <milang@tal.org>, linux-mips@linux-mips.org
Subject: Re: [PATCH] IP32 gbefb depth change fix
Date: Wed, 25 Jan 2006 14:24:43 +0000 [thread overview]
Message-ID: <20060125142443.GA4909@linux-mips.org> (raw)
In-Reply-To: <20060125141639.GA20977@deprecation.cyrius.com>
On Wed, Jan 25, 2006 at 02:16:39PM +0000, Martin Michlmayr wrote:
> * Kaj-Michael Lang <milang@tal.org> [2006-01-25 15:06]:
> > + info->fix.visual = FB_VISUAL_PSEUDOCOLOR;
>
> Minor note: there a trailing tab at the end of this line.
Many Linux developers use git-applymbox which has the habbit of removing
trailing whitespace. This may cause some inconvenience for the patch
submitter because what he's pulling back is different from what was
originally submitted.
Ralf
prev parent reply other threads:[~2006-01-25 14:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-25 13:06 [PATCH] IP32 gbefb depth change fix Kaj-Michael Lang
2006-01-25 13:33 ` Ralf Baechle
2006-01-25 14:16 ` Martin Michlmayr
2006-01-25 14:24 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060125142443.GA4909@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=milang@tal.org \
--cc=tbm@cyrius.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox