Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Martin Michlmayr <tbm@cyrius.com>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: linux-mips@linux-mips.org
Subject: Re: DECstation R3000 boot error
Date: Mon, 13 Feb 2006 23:23:29 +0000	[thread overview]
Message-ID: <20060213232329.GA8286@deprecation.cyrius.com> (raw)
In-Reply-To: <20060213225927.GB4226@deprecation.cyrius.com>

* Martin Michlmayr <tbm@cyrius.com> [2006-02-13 22:59]:
> BTW, turning CONFIG_VT on leads to these compile errors:

OK, I got it down to:

  CC      drivers/tc/lk201.o
drivers/tc/lk201.c: In function ‘lk201_rx_char’:
drivers/tc/lk201.c:361: warning: implicit declaration of function ‘handle_scancode’
drivers/tc/lk201.c: In function ‘lk201_init’:
drivers/tc/lk201.c:405: error: invalid lvalue in assignment
drivers/tc/lk201.c:406: error: invalid lvalue in assignment
make[2]: *** [drivers/tc/lk201.o] Error 1

But this driver really needs to be ported to the new input interface.


--- a/drivers/tc/lk201.c~	2006-02-13 22:59:57.000000000 +0000
+++ b/drivers/tc/lk201.c	2006-02-13 23:21:54.000000000 +0000
@@ -16,11 +16,9 @@
 #include <linux/kernel.h>
 #include <linux/init.h>
 #include <linux/delay.h>
-#include <linux/kbd_ll.h>
 #include <linux/kbd_kern.h>
 #include <linux/vt_kern.h>
 
-#include <asm/keyboard.h>
 #include <asm/dec/tc.h>
 #include <asm/dec/machtype.h>
 #include <asm/dec/serial.h>
@@ -186,28 +184,28 @@
 {
 	if (r->delay <= 0)
 		r->delay = kbdrate.delay;
-	if (r->rate <= 0)
-		r->rate = kbdrate.rate;
+	if (r->period <= 0)
+		r->period = kbdrate.period;
 
 	if (r->delay < 5)
 		r->delay = 5;
 	if (r->delay > 630)
 		r->delay = 630;
-	if (r->rate < 12)
-		r->rate = 12;
-	if (r->rate > 127)
-		r->rate = 127;
-	if (r->rate == 125)
-		r->rate = 124;
+	if (r->period < 12)
+		r->period = 12;
+	if (r->period > 127)
+		r->period = 127;
+	if (r->period == 125)
+		r->period = 124;
 }
 
 static int write_kbd_rate(struct kbd_repeat *rep)
 {
-	int delay, rate;
+	int delay, period;
 	int i;
 
 	delay = rep->delay / 5;
-	rate = rep->rate;
+	period = rep->period;
 	for (i = 0; i < 4; i++) {
 		if (lk201_hook.poll_tx_char(lk201_handle,
 					    LK_CMD_RPT_RATE(i)))
@@ -216,7 +214,7 @@
 					    LK_PARAM_DELAY(delay)))
 			return 1;
 		if (lk201_hook.poll_tx_char(lk201_handle,
-					    LK_PARAM_RATE(rate)))
+					    LK_PARAM_RATE(period)))
 			return 1;
 	}
 	return 0;


-- 
Martin Michlmayr
http://www.cyrius.com/

  reply	other threads:[~2006-02-13 23:17 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-23 22:50 DECstation R3000 boot error Martin Michlmayr
2006-01-24  9:50 ` Kaj-Michael Lang
2006-01-24 11:14   ` Maciej W. Rozycki
2006-01-25 10:42     ` Kaj-Michael Lang
2006-01-25 10:48       ` Martin Michlmayr
2006-01-25 11:16       ` Maciej W. Rozycki
2006-01-24 11:09 ` Maciej W. Rozycki
2006-01-24 12:27   ` Martin Michlmayr
2006-01-24 12:39     ` Maciej W. Rozycki
2006-01-24 23:21       ` Peter 'p2' De Schrijver
2006-01-24 23:36         ` Peter 'p2' De Schrijver
2006-01-25 11:10         ` Maciej W. Rozycki
2006-02-03 15:02           ` Martin Michlmayr
2006-02-06 10:38             ` Maciej W. Rozycki
2006-02-13  9:15               ` Maciej W. Rozycki
2006-02-13 22:39                 ` Martin Michlmayr
2006-02-13 22:47                   ` Martin Michlmayr
2006-02-14 16:27                     ` Ralf Baechle
2006-02-14 23:04                       ` Yoichi Yuasa
2006-02-14 16:25                   ` Ralf Baechle
2006-02-13 22:59                 ` Martin Michlmayr
2006-02-13 23:23                   ` Martin Michlmayr [this message]
2006-02-14 10:01                     ` Maciej W. Rozycki
2006-05-11 17:30                       ` Martin Michlmayr
2006-02-14  9:48                   ` Maciej W. Rozycki
2006-02-13 23:27                 ` Martin Michlmayr
2006-02-13 23:35                   ` Martin Michlmayr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060213232329.GA8286@deprecation.cyrius.com \
    --to=tbm@cyrius.com \
    --cc=linux-mips@linux-mips.org \
    --cc=macro@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox