From: Jon Anders Haugum <jonah@omegav.ntnu.no>
To: Jordan Crouse <jordan.crouse@amd.com>
Cc: linux-serial@vger.kernel.org, linux-mips@linux-mips.org
Subject: Re: [PATCH] Fix compile error in 8250_au1x00.c
Date: Thu, 2 Mar 2006 13:00:27 +0100 (CET) [thread overview]
Message-ID: <20060302124634.T81066@invalid.ed.ntnu.no> (raw)
In-Reply-To: <20060207211500.GC5227@cosmic.amd.com>
On Tue, 7 Feb 2006, Jordan Crouse wrote:
> There are additional rumors of strangeness on the DB1550, but those
> are unsubstantiated at this point. At least with this patch, it will
> compile.
I can confirm strangeness on Au1550, and I've pinned it down to wrong
way of setting the divisor register. The alchemy uart have got a spearate
register for divisor, while the driver tries to set the divisor latch
just like on any 16550 uart.
How would be a good way of solving this? I can imagine a couple of ways:
1. Make divisor latch read/write a bit more abstract, so that a
alternative function can be used for alchemy.
2. Add divisor latch to the alchemy uart register map. But since the
divisor register is located in a single 32-bit register and the driver
will try to access it one byte at a time; byte access would be needed. And
this would add some endian handling...
--
Jon Anders Haugum
prev parent reply other threads:[~2006-03-02 11:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-07 21:15 [PATCH] Fix compile error in 8250_au1x00.c Jordan Crouse
2006-02-08 21:36 ` Russell King
2006-03-02 12:00 ` Jon Anders Haugum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060302124634.T81066@invalid.ed.ntnu.no \
--to=jonah@omegav.ntnu.no \
--cc=jordan.crouse@amd.com \
--cc=linux-mips@linux-mips.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox