From: Martin Michlmayr <tbm@cyrius.com>
To: linux-mips@linux-mips.org
Subject: Re: [MIPS] Sibyte: Fix race in sb1250_gettimeoffset().
Date: Thu, 16 Mar 2006 14:11:27 +0000 [thread overview]
Message-ID: <20060316141127.GS25322@deprecation.cyrius.com> (raw)
In-Reply-To: <S8133620AbWCPM6I/20060316125808Z+139@ftp.linux-mips.org>
* linux-mips@linux-mips.org <linux-mips@linux-mips.org> [2006-03-16 12:57]:
> Commit: 186326fa1e0360450b927ee5b21fb8db028fe7ba
>
> +void __init swarm_time_init(void)
> +{
> + /* Setup HPT */
> + sb1250_hpt_setup();
> +}
This leads to compiler errors on 1480 because sb1250_hpt_setup() is
not defined. We need something like the patch below (or possibly a
proper fix?):
[MIPS] don't call sb1250_hpt_setup on 1480
sb1250_hpt_setup() should not be called on the 1480 board since it's
note defined there, leading to a linking error.
Signed-off-by: Martin Michlmayr <tbm@cyrius.com>
diff --git a/arch/mips/sibyte/swarm/setup.c b/arch/mips/sibyte/swarm/setup.c
index b661d24..4a93f1d 100644
--- a/arch/mips/sibyte/swarm/setup.c
+++ b/arch/mips/sibyte/swarm/setup.c
@@ -72,8 +72,10 @@ const char *get_system_type(void)
void __init swarm_time_init(void)
{
+#if defined(CONFIG_SIBYTE_SB1250) || defined(CONFIG_SIBYTE_BCM112X)
/* Setup HPT */
sb1250_hpt_setup();
+#endif
}
void __init swarm_timer_setup(struct irqaction *irq)
--
Martin Michlmayr
http://www.cyrius.com/
next parent reply other threads:[~2006-03-16 14:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <S8133620AbWCPM6I/20060316125808Z+139@ftp.linux-mips.org>
2006-03-16 14:11 ` Martin Michlmayr [this message]
2006-03-16 14:14 ` [MIPS] Sibyte: Fix race in sb1250_gettimeoffset() Martin Michlmayr
2006-05-24 12:51 ` Martin Michlmayr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060316141127.GS25322@deprecation.cyrius.com \
--to=tbm@cyrius.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox