From: Russell King <rmk@arm.linux.org.uk>
To: Martin Michlmayr <tbm@cyrius.com>
Cc: linux-mips@linux-mips.org, jblache@debian.org
Subject: Re: IP22 doesn't shutdown properly
Date: Sat, 25 Mar 2006 17:34:50 +0000 [thread overview]
Message-ID: <20060325173450.GC6100@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20060227105236.GI12044@deprecation.cyrius.com>
On Mon, Feb 27, 2006 at 10:52:36AM +0000, Martin Michlmayr wrote:
> @@ -360,10 +367,10 @@ static void ip22zilog_status_handle(stru
> * But it does not tell us which bit has changed, we have to keep
> * track of this ourselves.
> */
> - if ((status & DCD) ^ up->prev_status)
> + if ((status ^ up->prev_status) ^ DCD)
Shouldn't this be (status ^ up->prev_status) & DCD ?
> uart_handle_dcd_change(&up->port,
> (status & DCD));
> - if ((status & CTS) ^ up->prev_status)
> + if ((status ^ up->prev_status) ^ CTS)
Shouldn't this be (status ^ up->prev_status) & CTS ?
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2006-03-25 17:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-17 22:58 IP22 doesn't shutdown properly Martin Michlmayr
2006-02-18 1:19 ` Kumba
2006-02-18 1:27 ` Martin Michlmayr
2006-02-18 10:36 ` Julien BLACHE
2006-02-19 16:52 ` Ralf Baechle
2006-02-20 18:12 ` Martin Michlmayr
2006-02-20 21:55 ` Ralf Baechle
2006-02-21 13:59 ` Thiemo Seufer
2006-02-21 14:23 ` Stephen P. Becker
2006-02-21 14:31 ` Thiemo Seufer
2006-02-23 21:14 ` Martin Michlmayr
2006-02-23 22:13 ` Martin Michlmayr
2006-02-23 22:43 ` Russell King
2006-02-24 0:39 ` Martin Michlmayr
2006-02-24 1:30 ` Kumba
2006-02-24 8:31 ` Russell King
2006-02-27 10:54 ` Martin Michlmayr
2006-02-24 19:05 ` Christoph Hellwig
2006-02-27 10:51 ` Martin Michlmayr
2006-02-27 10:52 ` Martin Michlmayr
2006-02-27 11:22 ` Geert Uytterhoeven
2006-02-27 11:25 ` Martin Michlmayr
2006-02-27 12:53 ` Ralf Baechle
2006-02-27 18:30 ` Martin Michlmayr
2006-03-25 17:34 ` Russell King [this message]
2006-04-07 16:21 ` Martin Michlmayr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060325173450.GC6100@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=jblache@debian.org \
--cc=linux-mips@linux-mips.org \
--cc=tbm@cyrius.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox