From: "Jordan Crouse" <jordan.crouse@amd.com>
To: "Sergei Shtylyov" <sshtylyov@ru.mvista.com>
Cc: "Linux MIPS" <linux-mips@linux-mips.org>,
"Rodolfo Giometti" <giometti@linux.it>,
"Pete Popov" <ppopov@embeddedalley.com>
Subject: Re: Oops! - Re: Power management for au1000_eth.c
Date: Thu, 6 Apr 2006 11:10:21 -0600 [thread overview]
Message-ID: <20060406171021.GK22446@cosmic.amd.com> (raw)
In-Reply-To: <4435290C.50607@ru.mvista.com>
On 06/04/06 18:43 +0400, Sergei Shtylyov wrote:
> Hello.
>
> Rodolfo Giometti wrote:
>
> >>>I'm trying to add power management support to au1000_eth.c driver.
>
> >>Solved! :)
>
> >>Here a patch to implement power management functions for au1000_eth.
>
> Actually, the network driver patches should be sent to Jeff Garzik and
> Andrew Morton.
And the description is wrong - this isn't exactly just power management,
there are lots of changes here. You should separate them out into multiple
patches.
> >>Note that this patch needs my previous one who implements new power
> >>management's sysfs interface.
Thats OK, as long as this patch can be applied on its own, without requiring
the previous patch. It is one thing to write a new PM interface for the
whole system, but the driver suspend and resume functions should never be
system specific. That makes life easier for future developers.
> Funny, I've also been cooking a patch to straighten Alchemy Ethernet
> probing code a bit...
I think we can all get along here. The PM stuff looks decent to me, and
Sergei had some good comments about the rest of the patch. I don't see
any reason why the two of you can't get together and bang out a few patches
to fix all of our ills.
Jordan
--
Jordan Crouse
Senior Linux Engineer
AMD - Personal Connectivity Solutions Group
<www.amd.com/embeddedprocessors>
prev parent reply other threads:[~2006-04-06 16:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-05 15:47 Power management for au1000_eth.c Rodolfo Giometti
2006-04-05 22:23 ` Rodolfo Giometti
2006-04-05 22:26 ` [PATCH] Oops! - " Rodolfo Giometti
2006-04-06 14:43 ` Sergei Shtylyov
2006-04-06 15:50 ` Rodolfo Giometti
2006-04-19 18:46 ` [PATCH] au1000_eth.c probe code straightened up Sergei Shtylyov
2006-05-02 15:09 ` [PATCH] au1000_eth.c Power Management, driver registration and module support Rodolfo Giometti
2006-05-03 7:47 ` Rodolfo Giometti
2006-05-31 15:01 ` Sergei Shtylyov
2006-05-31 15:21 ` Rodolfo Giometti
2006-04-06 17:10 ` Jordan Crouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060406171021.GK22446@cosmic.amd.com \
--to=jordan.crouse@amd.com \
--cc=giometti@linux.it \
--cc=linux-mips@linux-mips.org \
--cc=ppopov@embeddedalley.com \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox