From: Ralf Baechle <ralf@linux-mips.org>
To: Win Treese <treese@acm.org>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] fix branch emulation for floating-point exceptions
Date: Wed, 26 Apr 2006 22:28:57 +0100 [thread overview]
Message-ID: <20060426212857.GA21114@linux-mips.org> (raw)
In-Reply-To: <9B3838B8-4950-40BA-B386-0D45819C168D@acm.org>
On Wed, Apr 26, 2006 at 03:22:22PM -0400, Win Treese wrote:
> In the branch emulation for floating-point exceptions,
> __compute_return_epc
> must determine for bc1f et al which condition code bit to test. This
> is based on bits <4:2>
> of the rt field. The switch statement to distinguish bc1f et al needs
> to use only the
> two low bits of rt, but the old code tests on the whole rt field.
> This patch masks off
> the proper bits.
One of those bugs that have managed to hide since day one ... I applied
your fix but: your mailer is converting tabs to spaces, so patch is going
to barf on the patch ...
> Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed
^^^^^^^^^^^^^
... and it would also break long lines ...
Ralf
prev parent reply other threads:[~2006-04-26 21:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-26 19:22 [PATCH] fix branch emulation for floating-point exceptions Win Treese
2006-04-26 21:28 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060426212857.GA21114@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=treese@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox