From: Martin Michlmayr <tbm@cyrius.com>
To: dmitry pervushin <dpervushin@ru.mvista.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] NEC EMMA2RH support
Date: Thu, 18 May 2006 12:12:12 +0200 [thread overview]
Message-ID: <20060518101212.GI7018@deprecation.cyrius.com> (raw)
In-Reply-To: <1147946423.8223.4.camel@diimka-laptop>
Some minor comments regarding the coding style:
* dmitry pervushin <dpervushin@ru.mvista.com> [2006-05-18 14:00]:
> + Features : kernel debugging, serial terminal, NFS root fs, on-board
There shouldn't be a space before the colon.
> ===================================================================
> --- linux-malta.orig/arch/mips/Makefile
> +++ linux-malta/arch/mips/Makefile
> @@ -196,7 +196,7 @@ cflags-$(CONFIG_CPU_MIPS64R2) += \
>
> cflags-$(CONFIG_CPU_R5000) += \
> $(call set_gccflags,r5000,mips4,r5000,mips4,mips2) \
> - -Wa,--trap
> + -Wa,--trap
>
> cflags-$(CONFIG_CPU_R5432) += \
> $(call set_gccflags,r5400,mips4,r5000,mips4,mips2) \
> @@ -776,7 +776,7 @@ archclean:
> @$(MAKE) $(clean)=arch/mips/boot
> @$(MAKE) $(clean)=arch/mips/lasat
>
> -# Generate <asm/offset.h
> +# Generate <asm/offset.h
Those unrelated changes shouldn't be made.
> +// #include <linux/kdev_t.h>
> +#include <linux/types.h>
> +// #include <linux/sched.h>
> +// #include <linux/pci.h>
I think C++ style comments should't be used in the kernel. In any
case, you could just remove them if they're not used.
--
Martin Michlmayr
http://www.cyrius.com/
next prev parent reply other threads:[~2006-05-18 10:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-18 10:00 [PATCH] NEC EMMA2RH support dmitry pervushin
2006-05-18 10:12 ` Martin Michlmayr [this message]
2006-05-18 10:34 ` dmitry pervushin
2006-05-18 10:54 ` Yoichi Yuasa
2006-05-18 11:08 ` dmitry pervushin
2006-05-18 11:17 ` Thiemo Seufer
2006-05-19 10:52 ` Ralf Baechle
2006-05-18 18:28 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060518101212.GI7018@deprecation.cyrius.com \
--to=tbm@cyrius.com \
--cc=dpervushin@ru.mvista.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox