From: Ralf Baechle <ralf@linux-mips.org>
To: Daniel Jacobowitz <dan@debian.org>
Cc: "Joseph S. Myers" <joseph@codesourcery.com>, linux-mips@linux-mips.org
Subject: Re: N32 sigset and __COMPAT_ENDIAN_SWAP__
Date: Thu, 8 Jun 2006 18:36:58 +0100 [thread overview]
Message-ID: <20060608173658.GA4056@linux-mips.org> (raw)
In-Reply-To: <20060608170310.GA23814@nevyn.them.org>
On Thu, Jun 08, 2006 at 01:03:10PM -0400, Daniel Jacobowitz wrote:
> Anyway, I was curious if you knew where this code had come from. I
> didn't see anything to suggest that anyone besides mipsel ever
> used it, but it entered linux-mips.org via a merge from kernel.org,
> just before git history.
>
> Oh, right, there's a historical import:
>
> http://www.kernel.org/git/?p=linux/kernel/git/torvalds/old-2.6-bkcvs.git;a=commitdiff;h=32ed691a4efbc1c43584b7b7a6d782528241bb27
> It was copied from sys32_rt_sigtimedwait, which was wrong at least back
> to the initial revision of signal32.c. I didn't go back any further.
I can further track it into 2.4 or even pre-2.4 where such
__MIPSEB__ / __MIPSEL__ dependencies did exist under arch/mips64/.
I think it was right until a certain point in 2.5 when
get_sigset and put_sigset were implement in a clever way that
automatically takes care of the endianess issue - but the swapping code
outside arch/mips got forgotten.
Ralf
next prev parent reply other threads:[~2006-06-08 17:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-08 1:36 N32 sigset and __COMPAT_ENDIAN_SWAP__ Joseph S. Myers
2006-06-08 2:25 ` Kumba
2006-06-08 2:28 ` Daniel Jacobowitz
2006-06-08 2:38 ` Kumba
2006-06-08 2:45 ` Kumba
2006-06-08 16:51 ` Ralf Baechle
2006-06-08 17:03 ` Daniel Jacobowitz
2006-06-08 17:36 ` Ralf Baechle [this message]
2006-06-08 17:12 ` Joseph S. Myers
2006-06-09 1:15 ` Kumba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060608173658.GA4056@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=dan@debian.org \
--cc=joseph@codesourcery.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox