From: Ralf Baechle <ralf@linux-mips.org>
To: Rodolfo Giometti <giometti@linux.it>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] APM (emu) support
Date: Tue, 13 Jun 2006 14:34:37 +0100 [thread overview]
Message-ID: <20060613133437.GA9186@linux-mips.org> (raw)
In-Reply-To: <20060605154310.GF27426@enneenne.com>
On Mon, Jun 05, 2006 at 05:43:10PM +0200, Rodolfo Giometti wrote:
> here my proposal to add APM (emu) support into mips tree. It's just
> the one for ARM adapted...
>
> I have tested it on my au1100 based board with a battery pack. Also
> the command:
>
> $ apm --suspend
>
> works correctly!
Looking good, indeed.
There is a sore spot though. Your patch creates arch/mips/kernel/apm.c
as an essentially unmodified copy of arch/arch/kernel/apm.c and the
latter as you have found is actually portable code. So I suggest you
rather move that file to drivers/char/ and use it for both architectures.
Ralf
prev parent reply other threads:[~2006-06-13 13:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-05 15:43 [PATCH] APM (emu) support Rodolfo Giometti
2006-06-13 13:34 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060613133437.GA9186@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=giometti@linux.it \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox