From: Thiemo Seufer <ths@networkno.de>
To: Martin Michlmayr <tbm@cyrius.com>
Cc: linux-mips@linux-mips.org, Roger Leigh <rleigh@debian.org>,
380531-silent@bugs.debian.org
Subject: Re: Bug#380531: linux-2.6: mips and mipsel personality(2) support is broken
Date: Mon, 31 Jul 2006 00:19:19 +0100 [thread overview]
Message-ID: <20060730231919.GD15011@networkno.de> (raw)
In-Reply-To: <20060730224137.GP17134@deprecation.cyrius.com>
Martin Michlmayr wrote:
> FYI, but report tht "mips and mipsel personality(2) support is broken"
This patch fixes sys_personality for the o32 emulation by
a) killing the sign extension bits
b) tighten the bitmask match for current->personality (like it is done
for x86_64)
Thiemo
Signed-off-by: Thiemo Seufer <ths@networkno.de>
--- a/arch/mips/kernel/linux32.c
+++ b/arch/mips/kernel/linux32.c
@@ -1053,7 +1053,9 @@ asmlinkage long sys32_newuname(struct ne
asmlinkage int sys32_personality(unsigned long personality)
{
int ret;
- if (current->personality == PER_LINUX32 && personality == PER_LINUX)
+ personality &= 0xffffffff;
+ if (personality(current->personality) == PER_LINUX32 &&
+ personality == PER_LINUX)
personality = PER_LINUX32;
ret = sys_personality(personality);
if (ret == PER_LINUX32)
next prev parent reply other threads:[~2006-07-30 23:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060730183939.7119.48747.reportbug@hardknott.home.whinlatter.ukfsn.org>
2006-07-30 22:41 ` Bug#380531: linux-2.6: mips and mipsel personality(2) support is broken Martin Michlmayr
2006-07-30 23:19 ` Thiemo Seufer [this message]
2006-07-30 23:20 ` Roger Leigh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060730231919.GD15011@networkno.de \
--to=ths@networkno.de \
--cc=380531-silent@bugs.debian.org \
--cc=linux-mips@linux-mips.org \
--cc=rleigh@debian.org \
--cc=tbm@cyrius.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox