From: Rodolfo Giometti <giometti@linux.it>
To: linux-mips@linux-mips.org
Subject: [PATCH] 5/7 AU1100 MMC support
Date: Wed, 9 Aug 2006 23:11:00 +0200 [thread overview]
Message-ID: <20060809211100.GF13145@enneenne.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 346 bytes --]
Interrupt management fix up.
Signed-off-by: Rodolfo Giometti <giometti@linux.it>
--
GNU/Linux Solutions e-mail: giometti@enneenne.com
Linux Device Driver giometti@gnudd.com
Embedded Systems giometti@linux.it
UNIX programming phone: +39 349 2432127
[-- Attachment #2: patch-mmc-irq-fix --]
[-- Type: text/plain, Size: 1143 bytes --]
diff --git a/drivers/mmc/au1xmmc.c b/drivers/mmc/au1xmmc.c
index 10e8e06..f2d44cd 100644
--- a/drivers/mmc/au1xmmc.c
+++ b/drivers/mmc/au1xmmc.c
@@ -772,11 +772,7 @@ static irqreturn_t au1xmmc_irq(int irq,
{
struct au1xmmc_host *host = dev_id;
u32 status;
- int i, ret = 0;
-
- disable_irq(AU1100_SD_IRQ);
-
- u32 handled = 1;
+ int ret = IRQ_HANDLED;
status = au_readl(HOST_STATUS(host));
@@ -821,15 +817,12 @@ #endif
}
else if (status & 0x203FBC70) {
dbg("Unhandled status %8.8x\n", host->id, status);
- handled = 0;
+ ret = IRQ_NONE;
}
au_writel(status, HOST_STATUS(host));
au_sync();
- ret |= handled;
-
- enable_irq(AU1100_SD_IRQ);
return ret;
}
@@ -987,7 +980,6 @@ static int __devinit au1xmmc_probe(struc
info("MMC controller set up at %x irq %d (mode=%s)\n",
host->id, base_addr_phys, host->irq, dma ? "dma" : "pio");
- enable_irq(AU1100_SD_IRQ);
platform_set_drvdata(pdev, host);
return 0;
@@ -1021,8 +1013,6 @@ static int __devexit au1xmmc_remove(stru
if (!host)
return 0;
- disable_irq(AU1100_SD_IRQ);
-
tasklet_kill(&host->data_task);
tasklet_kill(&host->finish_task);
reply other threads:[~2006-08-09 21:10 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060809211100.GF13145@enneenne.com \
--to=giometti@linux.it \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox