Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: "Kevin D. Kissell" <KevinK@mips.com>
Cc: linux-mips@linux-mips.org, Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH] ret_from_irq adjustment
Date: Sun, 8 Oct 2006 22:44:43 +0100	[thread overview]
Message-ID: <20061008214443.GA6254@linux-mips.org> (raw)
In-Reply-To: <006501c6eb07$4fbf66c0$8003a8c0@Ulysses>

On Sun, Oct 08, 2006 at 08:26:44PM +0200, Kevin D. Kissell wrote:

> While setting up ra "by hand" and transferring control via the jr
> is a reasonable optimization, you're otherwise breaking things for SMTC.
> While the comments are misleading (they accurately described an earlier
> version of the code), the function being called here is ipi_decode(), which
>  needs a pt_regs * in the first argument (hence the copy of the sp), and 
> the pointer to the IPI message descriptor in the second.
> 
> Do you have access to a 34K to test changes to SMTC?  I'd have
> expected this one to have been pretty quickly fatal.

The shakeup of the code by the recent series of pt_regs related cleanups
is pretty massive.  As of last night I only had uniprocessor support
working again.  VSMP and SMTC were broken; actual multi-core CPU not
tested yet.

  Ralf

  parent reply	other threads:[~2006-10-08 21:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-08 16:24 [PATCH] ret_from_irq adjustment Atsushi Nemoto
2006-10-08 18:26 ` Kevin D. Kissell
2006-10-08 18:26   ` Kevin D. Kissell
2006-10-08 21:44   ` Ralf Baechle [this message]
2006-10-09 10:43   ` Kevin D. Kissell
2006-10-09 10:43     ` Kevin D. Kissell
2006-10-09 13:53   ` Ralf Baechle
2006-10-09 14:40     ` Atsushi Nemoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061008214443.GA6254@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=KevinK@mips.com \
    --cc=anemo@mba.ocn.ne.jp \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox