From: Ralf Baechle <ralf@linux-mips.org>
To: Kaz Kylheku <kaz@zeugmasystems.com>
Cc: linux-mips@linux-mips.org
Subject: Re: N32 shmat problem identified! Kernel fix needed.
Date: Sat, 2 Dec 2006 02:24:04 +0000 [thread overview]
Message-ID: <20061202022404.GA28637@linux-mips.org> (raw)
In-Reply-To: <66910A579C9312469A7DF9ADB54A8B7D4B5F5F@exchange.ZeugmaSystems.local>
On Fri, Dec 01, 2006 at 04:33:16PM -0800, Kaz Kylheku wrote:
> The function named sys32_shmat has no reason to exist, and is broken. It
> assumes that user space has passed a pointer to the location where the
> resulting pointer should be stored. But that is not the shmat API, and
> glibc will pass no such parameter. So a null dereference results,
> leading to EFAULT.
>
> The fix is to remove this function from the code base and quite simply
> to wire the normal sys_shmat into the n32 syscall table. Since there is
> in fact no pointer-to-pointer argument, this function doesn't have a 32
> bit compatibility issues.
That's fixed since two months.
Ralf
next prev parent reply other threads:[~2006-12-02 2:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-02 0:33 N32 shmat problem identified! Kernel fix needed Kaz Kylheku
2006-12-02 0:33 ` Kaz Kylheku
2006-12-02 2:24 ` Ralf Baechle [this message]
2006-12-03 13:42 ` Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061202022404.GA28637@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=kaz@zeugmasystems.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox