From: Ralf Baechle <ralf@linux-mips.org>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] Make __declare_dbe_table() static
Date: Sun, 18 Feb 2007 16:13:52 +0000 [thread overview]
Message-ID: <20070218161352.GC24660@linux-mips.org> (raw)
In-Reply-To: <20070219.005850.96686775.anemo@mba.ocn.ne.jp>
On Mon, Feb 19, 2007 at 12:58:50AM +0900, Atsushi Nemoto wrote:
> On Sun, 18 Feb 2007 15:54:08 +0000, Ralf Baechle <ralf@linux-mips.org> wrote:
> > > Make __declare_dbe_table() static and call it explicitly to ensure not
> > > optimized out.
> >
> > That's what __attribute_used__ was meant to be used for.
>
> But we do not need empty __declare_dbe_table() function body (jr ra +
> nop) at all. If we called it explicitly, compiler will optimized it
> out. Saves two instructions ;)
_asm__(
" .section __dbe_table, \"a\"\n"
" .previous \n");
is even simpler :-)
Ralf
next prev parent reply other threads:[~2007-02-18 16:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-18 15:44 [PATCH] Make __declare_dbe_table() static Atsushi Nemoto
2007-02-18 15:54 ` Ralf Baechle
2007-02-18 15:58 ` Atsushi Nemoto
2007-02-18 16:13 ` Ralf Baechle [this message]
2007-02-18 16:20 ` Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070218161352.GC24660@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox